linux-kernel - [PATCH 5.10 2/2] gfs2: Fix slab-use-after-free in gfs2_qd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20250110183213.105051-3-kovalev@altlinux.org>
Date: Fri, 10 Jan 2025 21:32:13 +0300
From: Vasiliy Kovalev <kovalev@...linux.org>
To: stable@...r.kernel.org
Cc: Bob Peterson <rpeterso@...hat.com>,
	Andreas Gruenbacher <agruenba@...hat.com>,
	linux-kernel@...r.kernel.org,
	Juntong Deng <juntong.deng@...look.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Clayton Casciato <majortomtosourcecontrol@...il.com>,
	lvc-project@...uxtesting.org,
	kovalev@...linux.org
Subject: [PATCH 5.10 2/2] gfs2: Fix slab-use-after-free in gfs2_qd_dealloc

From: Juntong Deng <juntong.deng@...look.com>

commit bdcb8aa434c6d36b5c215d02a9ef07551be25a37 upstream.

In gfs2_put_super(), whether withdrawn or not, the quota should
be cleaned up by gfs2_quota_cleanup().

Otherwise, struct gfs2_sbd will be freed before gfs2_qd_dealloc (rcu
callback) has run for all gfs2_quota_data objects, resulting in
use-after-free.

Also, gfs2_destroy_threads() and gfs2_quota_cleanup() is already called
by gfs2_make_fs_ro(), so in gfs2_put_super(), after calling
gfs2_make_fs_ro(), there is no need to call them again.

Reported-by: syzbot+29c47e9e51895928698c@...kaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=29c47e9e51895928698c
Signed-off-by: Juntong Deng <juntong.deng@...look.com>
Signed-off-by: Andreas Gruenbacher <agruenba@...hat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Signed-off-by: Clayton Casciato <majortomtosourcecontrol@...il.com>
(cherry picked from commit 7ad4e0a4f61c57c3ca291ee010a9d677d0199fba)
Signed-off-by: Vasiliy Kovalev <kovalev@...linux.org>
---
 fs/gfs2/super.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/gfs2/super.c b/fs/gfs2/super.c
index a9e3956a5b4698..d4399bec7b5b12 100644
--- a/fs/gfs2/super.c
+++ b/fs/gfs2/super.c
@@ -623,6 +623,8 @@ static void gfs2_put_super(struct super_block *sb)
 
 	if (!sb_rdonly(sb)) {
 		gfs2_make_fs_ro(sdp);
+	} else {
+		gfs2_quota_cleanup(sdp);
 	}
 	WARN_ON(gfs2_withdrawing(sdp));
 
-- 
2.33.8