linux-kernel - Re: [PATCH] kbuild: Strip runtime const RELA sections correctly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wiGfhxb4q4T2=W=Vg=sHwZwwMTN2EaDYbmS0VG1Srdb-w@mail.gmail.com>
Date: Fri, 10 Jan 2025 10:32:54 -0800
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: Ard Biesheuvel <ardb@...nel.org>
Cc: Masahiro Yamada <masahiroy@...nel.org>, Ard Biesheuvel <ardb+git@...gle.com>, 
	linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-riscv@...ts.infradead.org, linux-s390@...r.kernel.org
Subject: Re: [PATCH] kbuild: Strip runtime const RELA sections correctly

On Fri, 10 Jan 2025 at 10:11, Ard Biesheuvel <ardb@...nel.org> wrote:
>
> I suppose this is a consequence of 8962b6b475bddc ("kbuild: print
> short log in addition to the whole command with V=1") which introduced
> an $(if ) where the else branch is simply ':' and so it always
> succeeds.

Hmm. Odd. I don't see why that part of the commit exists, and you're
right, that seems like a bad idea.

And removing that odd $(if..) and making it just do

   cmd = @set -e; $($(quiet)log_print) $(delete-on-interrupt) $(cmd_$(1))

doesn't seem to have any obvious negative effects.

I'm probably missing some obvious reason why that $(if..) was added,
it's been that way for two years now.

           Linus