linux-kernel - Re: [PATCH v1 6/6] mm/hugetlb: use folio->lru int demote_free_hugetlb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z4FuA-OJkygYTOT6@casper.infradead.org>
Date: Fri, 10 Jan 2025 18:59:15 +0000
From: Matthew Wilcox <willy@...radead.org>
To: David Hildenbrand <david@...hat.com>
Cc: linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Muchun Song <muchun.song@...ux.dev>
Subject: Re: [PATCH v1 6/6] mm/hugetlb: use folio->lru int
 demote_free_hugetlb_folios()

On Fri, Jan 10, 2025 at 07:21:49PM +0100, David Hildenbrand wrote:
> We are demoting hugetlb folios to smaller hugetlb folios; let's avoid
> messing with pages where avoidable.
> 
> Signed-off-by: David Hildenbrand <david@...hat.com>

Good stuff.  I have questions.

> +++ b/mm/hugetlb.c
> @@ -3822,13 +3822,15 @@ static long demote_free_hugetlb_folios(struct hstate *src, struct hstate *dst,
>  
>  		for (i = 0; i < pages_per_huge_page(src); i += pages_per_huge_page(dst)) {
>  			struct page *page = folio_page(folio, i);
> +			struct folio *new_folio;

I'm usually very against casting from page to folio, but I think it
might be the better option in this case ...

>  			page->mapping = NULL;

because then we could do new_folio->mapping = NULL.

We're going to have to do serious changes to this function anyway to
convert from Ottawa to the New York interpretation, so the cast doesn't
give me the feeling of danger that it would elsewhere.

>  			clear_compound_head(page);
>  			prep_compound_page(page, dst->order);
> +			new_folio = page_folio(page);
>  
> -			init_new_hugetlb_folio(dst, page_folio(page));
> -			list_add(&page->lru, &dst_list);
> +			init_new_hugetlb_folio(dst, new_folio);
> +			list_add(&new_folio->lru, &dst_list);
>  		}
>  	}
>  
> -- 
> 2.47.1
>