linux-kernel - Re: [PATCH v4 03/14] of: Make of_property_present() applicable to all kinds of property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cce3520f-389c-44f9-9c55-9b925bfc6f91@icloud.com>
Date: Sat, 11 Jan 2025 06:59:22 +0800
From: Zijun Hu <zijun_hu@...oud.com>
To: Rob Herring <robh@...nel.org>
Cc: Saravana Kannan <saravanak@...gle.com>, Maxime Ripard
 <mripard@...nel.org>, Robin Murphy <robin.murphy@....com>,
 Grant Likely <grant.likely@...retlab.ca>, Marc Zyngier <maz@...nel.org>,
 Andreas Herrmann <andreas.herrmann@...xeda.com>,
 Marek Szyprowski <m.szyprowski@...sung.com>,
 Catalin Marinas <catalin.marinas@....com>, Mike Rapoport <rppt@...nel.org>,
 Oreoluwa Babatunde <quic_obabatun@...cinc.com>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, Zijun Hu <quic_zijuhu@...cinc.com>
Subject: Re: [PATCH v4 03/14] of: Make of_property_present() applicable to all
 kinds of property

On 2025/1/11 01:45, Rob Herring wrote:
> On Thu, Jan 09, 2025 at 09:26:54PM +0800, Zijun Hu wrote:
>> From: Zijun Hu <quic_zijuhu@...cinc.com>
>>
>> API of_property_present() invokes of_property_read_bool() to check if
>> a property is present or not, and that has 2 shortcomings shown below:
>>
>> - That narrows down property scope applicable to of_property_present()
>>   from all kinds of property to only bool type.
>>
>> - That is less logical since it says a property's presence is decided by
>>   its bool property value.
>>
>> Fix by making of_property_read_bool() invoke of_property_present().
> 
> I already indicated I wasn't interested in taking this until we have 
> reason to split the behavior. I've sent out a series on that now[1].
> 

the patch you indicate is patch [4/14] as below, not this patch [3/14]
https://lore.kernel.org/all/CAL_JsqJvh5pddoVEgaKQvGth0ncgtC9AAGxMEiK__NiZKrjmxA@mail.gmail.com/

the actual change of this patch is only to swap function name between
of_property_present() and of_property_read_bool() even if it seems this
patch has many changed lines.

okay, let me drop this patch in v5. (^^)

> Rob
> 
> [1] https://lore.kernel.org/all/20250109-dt-type-warnings-v1-0-0150e32e716c@kernel.org/