linux-kernel - Re: [PATCH] checkpatch: don't warn about extra parentheses in staging/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <44153a27346ff2e8dc9a2c4b04aa4bb0be09d471.camel@perches.com>
Date: Thu, 09 Jan 2025 23:32:52 -0800
From: Joe Perches <joe@...ches.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Dan Carpenter
	 <dan.carpenter@...aro.org>, Andrew Morton <akpm@...ux-foundation.org>
Cc: Andy Whitcroft <apw@...onical.com>, Dwaipayan Ray
 <dwaipayanray1@...il.com>,  Lukas Bulwahn <lukas.bulwahn@...il.com>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkpatch: don't warn about extra parentheses in
 staging/

On Fri, 2025-01-10 at 08:18 +0100, Greg Kroah-Hartman wrote:
> On Fri, Jan 10, 2025 at 10:12:17AM +0300, Dan Carpenter wrote:
> > This "Unnecessary parentheses" warning is disabled for drivers/staging
> > unless the --strict option is used.  Really, we don't want it at all
> > even if the --strict option is used.
> > 
> > Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> > ---
> >  scripts/checkpatch.pl | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > index fdf07c897471..628aa9e17e91 100755
> > --- a/scripts/checkpatch.pl
> > +++ b/scripts/checkpatch.pl
> > @@ -5513,9 +5513,9 @@ sub process {
> >  			}
> >  		}
> >  
> > -# check for unnecessary parentheses around comparisons in if uses
> > -# when !drivers/staging or command-line uses --strict
> > -		if (($realfile !~ m@^(?:drivers/staging/)@ || $check_orig) &&
> > +# check for unnecessary parentheses around comparisons
> > +# except in drivers/staging
> > +		if (($realfile !~ m@^(?:drivers/staging/)@) &&
> >  		    $perl_version_ok && defined($stat) &&
> >  		    $stat =~ /(^.\s*if\s*($balanced_parens))/) {
> >  			my $if_stat = $1;
> > -- 
> > 2.45.2
> > 
> 
> Yes!  Thanks for this:
> 
> Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

I have no issue with this.
Andrew, please apply it.