linux-kernel - Re: [PATCH v2 00/17] rockchip: Add rk3562 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <3460b2a3-9579-4a12-9eff-6e2f1a1cc91c@rock-chips.com>
Date: Fri, 10 Jan 2025 15:58:44 +0800
From: Kever Yang <kever.yang@...k-chips.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: heiko@...ech.de, linux-rockchip@...ts.infradead.org,
 Simon Xue <xxm@...k-chips.com>, Guenter Roeck <linux@...ck-us.net>,
 Mark Brown <broonie@...nel.org>, Chris Morgan <macromorgan@...mail.com>,
 Frank Wang <frank.wang@...k-chips.com>, Jamie Iles <jamie@...ieiles.com>,
 Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org,
 Jonas Karlman <jonas@...boo.se>, Johan Jonker <jbx6244@...il.com>,
 David Airlie <airlied@...il.com>, dri-devel@...ts.freedesktop.org,
 Sebastian Reichel <sebastian.reichel@...labora.com>,
 linux-i2c@...r.kernel.org, Shawn Lin <shawn.lin@...k-chips.com>,
 Simona Vetter <simona@...ll.ch>, Elaine Zhang <zhangqing@...k-chips.com>,
 Conor Dooley <conor+dt@...nel.org>, Finley Xiao
 <finley.xiao@...k-chips.com>, Maxime Ripard <mripard@...nel.org>,
 Krzysztof Wilczyński <kw@...ux.com>,
 FUKAUMI Naoki <naoki@...xa.com>, linux-pwm@...r.kernel.org,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Andy Yan <andyshrk@....com>,
 linux-serial@...r.kernel.org, Michael Riesch
 <michael.riesch@...fvision.net>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Jiri Slaby <jirislaby@...nel.org>, Andi Shyti <andi.shyti@...nel.org>,
 devicetree@...r.kernel.org, Diederik de Haas <didi.debian@...ow.org>,
 linux-watchdog@...r.kernel.org, Rob Herring <robh@...nel.org>,
 Lee Jones <lee@...nel.org>,
 Cristian Ciocaltea <cristian.ciocaltea@...labora.com>,
 Wim Van Sebroeck <wim@...ux-watchdog.org>,
 Shresth Prasad <shresthprasad7@...il.com>, Tim Lunn <tim@...thertop.org>,
 Lorenzo Pieralisi <lpieralisi@...nel.org>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 linux-arm-kernel@...ts.infradead.org, Ulf Hansson <ulf.hansson@...aro.org>,
 Jisheng Zhang <jszhang@...nel.org>, Dragan Simic <dsimic@...jaro.org>,
 Detlev Casanova <detlev.casanova@...labora.com>, linux-mmc@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-spi@...r.kernel.org,
 linux-usb@...r.kernel.org,
 Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
 Thomas Zimmermann <tzimmermann@...e.de>,
 Uwe Kleine-König <ukleinek@...nel.org>
Subject: Re: [PATCH v2 00/17] rockchip: Add rk3562 support

Hi Krzysztof,

     Thanks very much for your review.

On 2024/12/27 15:38, Krzysztof Kozlowski wrote:
> On Tue, Dec 24, 2024 at 05:49:03PM +0800, Kever Yang wrote:
>> This patch set adds rk3562 SoC and its evb support.
>>
>> Split out patches belong to different subsystem.
>>
>> Test with GMAC, USB, PCIe, EMMC, SD Card.
>>
>> This patch set is base on the patche set for rk3576 evb1 support.
>>
>> Changes in v2:
>> - Update in sort order
>> - remove grf in cru
>> - Update some properties order
>>
>> Finley Xiao (2):
>>    arm64: dts: rockchip: add core dtsi for RK3562 Soc
>>    arm64: dts: rockchip: Add RK3562 evb2 devicetree
>>
>> Kever Yang (15):
>>    dt-bindings: PCI: dwc: rockchip: Add rk3562 support
>>    dt-bindings: mmc: Add support for rk3562 eMMC
>>    dt-bindings: mmc: rockchip-dw-mshc: Add rk3562 compatible string
>>    dt-bindings: power: rockchip: Add bindings for rk3562
>>    dt-bindings: i2c: i2c-rk3x: Add rk3562 compatible
>>    dt-bindings: gpu: Add rockchip,rk3562-mali compatible
>>    dt-bindings: watchdog: Add rk3562 compatible
>>    dt-bindings: spi: Add rockchip,rk3562-spi compatible
>>    dt-bindings: serial: snps-dw-apb-uart: Add support for rk3562
>>    dt-bindings: usb: dwc3: add compatible for rk3562
>>    dt-bindings: pwm: rockchip: Add rockchip,rk3562-pwm
>>    dt-bindings: rockchip: pmu: Add rk3562 compatible
>>    dt-bindings: soc: rockchip: Add rk3562 syscon compatibles
>>    dt-bindings: arm: rockchip: Add rk3562 evb2 board
>>    dt-bindings: mfd: syscon: Add rk3562 QoS register compatible
> You squezzed here like 12 different subsystems. Some of these changes
> suggest missing drivers.
I have split out all the patches with driver change as separate patch set.
All the other dt-binding patches in this patchset is re-use the driver 
without any change,
but only add a new "rockchip, rk3562-" based compatible entry, and also 
no more info
need to explain in the commit message which I usually copy from commit 
msg already in tree
and change the soc to rk3562.
I think this patch set will be clear enough for the new soc/board 
support. So do you mean
I have to send the 1st~15th of this patchset one by one separately so 
that they can reach
to different subsystems? I believe there is no much useful change for 
the cc list is provide
by the tool automatically and the commit msg can update as Uwe's 
suggestion:

	The PWM core on Rockchip's RK3562 is the same as the one already
	included in RK3328. Extend the binding accordingly to allow

		compatible = "rockchip,rk3562-pwm", "rockchip,rk3328-pwm";

Thanks,
- Kever


>
> Please read basic upstreaming guide, some previous discussions and get
> internal rock-chips help so we want repeat basics over and over.
>
> Bindings are with drivers. Send them to respective subsystems.
>
> Best regards,
> Krzysztof
>
>