linux-kernel - Re: [PATCH] uio: uio_dmem_genirq: check the return value of devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=MfMehi+kU=xopv6Ued2mYyZk5wrv1i_OBYMC0XW8aPdMQ@mail.gmail.com>
Date: Fri, 10 Jan 2025 09:41:16 +0100
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Rob Herring <robh@...nel.org>
Cc: linux-kernel@...r.kernel.org, 
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH] uio: uio_dmem_genirq: check the return value of devm_kasprintf()

On Mon, Dec 2, 2024 at 7:17 PM Bartosz Golaszewski <brgl@...ev.pl> wrote:
>
> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
>
> devm_kasprintf() can fail so check its return value and bail-out on no
> memory.
>
> Fixes: 52e2dc2ce2d8 ("uio: Convert a few more users to using %pOFn instead of device_node.name")
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> ---
>  drivers/uio/uio_dmem_genirq.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/uio/uio_dmem_genirq.c b/drivers/uio/uio_dmem_genirq.c
> index c70dd81bfc61f..31aa75110ba59 100644
> --- a/drivers/uio/uio_dmem_genirq.c
> +++ b/drivers/uio/uio_dmem_genirq.c
> @@ -167,6 +167,8 @@ static int uio_dmem_genirq_probe(struct platform_device *pdev)
>                 }
>                 uioinfo->name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "%pOFn",
>                                                pdev->dev.of_node);
> +               if (!uioinfo->name)
> +                       return -ENOMEM;
>                 uioinfo->version = "devicetree";
>         }
>
> --
> 2.45.2
>

Gentle ping?

Bartosz