linux-kernel - [PATCH] scsi: fnic: Return appropriate error code for mem alloc failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20250110091746.17671-1-kartilak@cisco.com>
Date: Fri, 10 Jan 2025 01:17:46 -0800
From: Karan Tilak Kumar <kartilak@...co.com>
To: sebaddel@...co.com
Cc: arulponn@...co.com,
	djhawar@...co.com,
	gcboffa@...co.com,
	mkai2@...co.com,
	satishkh@...co.com,
	aeasi@...co.com,
	jejb@...ux.ibm.com,
	martin.petersen@...cle.com,
	linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Karan Tilak Kumar <kartilak@...co.com>,
	Dan Carpenter <dan.carpenter@...aro.org>
Subject: [PATCH] scsi: fnic: Return appropriate error code for mem alloc failure

Return appropriate error code from fnic_probe when memory create slab
pool fails. Fix bug report.

Suggested-by: Dan Carpenter <dan.carpenter@...aro.org>
Reviewed-by: Sesidhar Baddela <sebaddel@...co.com>
Reviewed-by: Arulprabhu Ponnusamy <arulponn@...co.com>
Reviewed-by: Gian Carlo Boffa <gcboffa@...co.com>
Reviewed-by: Arun Easi <aeasi@...co.com>
Signed-off-by: Karan Tilak Kumar <kartilak@...co.com>
---
 drivers/scsi/fnic/fnic_main.c | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/drivers/scsi/fnic/fnic_main.c b/drivers/scsi/fnic/fnic_main.c
index b5dca8e7e2e4..d366cbca04d5 100644
--- a/drivers/scsi/fnic/fnic_main.c
+++ b/drivers/scsi/fnic/fnic_main.c
@@ -888,24 +888,32 @@ static int fnic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 	}
 
 	pool = mempool_create_slab_pool(2, fnic_sgl_cache[FNIC_SGL_CACHE_DFLT]);
-	if (!pool)
+	if (!pool) {
+		err = -ENOMEM;
 		goto err_out_free_resources;
+	}
 	fnic->io_sgl_pool[FNIC_SGL_CACHE_DFLT] = pool;
 
 	pool = mempool_create_slab_pool(2, fnic_sgl_cache[FNIC_SGL_CACHE_MAX]);
-	if (!pool)
+	if (!pool) {
+		err = -ENOMEM;
 		goto err_out_free_dflt_pool;
+	}
 	fnic->io_sgl_pool[FNIC_SGL_CACHE_MAX] = pool;
 
 	pool = mempool_create_slab_pool(FDLS_MIN_FRAMES, fdls_frame_cache);
-	if (!pool)
+	if (!pool) {
+		err = -ENOMEM;
 		goto err_out_fdls_frame_pool;
+	}
 	fnic->frame_pool = pool;
 
 	pool = mempool_create_slab_pool(FDLS_MIN_FRAME_ELEM,
 						fdls_frame_elem_cache);
-	if (!pool)
+	if (!pool) {
+		err = -ENOMEM;
 		goto err_out_fdls_frame_elem_pool;
+	}
 	fnic->frame_elem_pool = pool;
 
 	/* setup vlan config, hw inserts vlan header */
-- 
2.47.1