linux-kernel - RE: [EXTERNAL] Re: [net-next PATCH v2 3/6] octeontx2-pf: Add AF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SJ0PR18MB5216E69E76EEA7F4A1F0D386DB1C2@SJ0PR18MB5216.namprd18.prod.outlook.com>
Date: Fri, 10 Jan 2025 09:34:20 +0000
From: Suman Ghosh <sumang@...vell.com>
To: Simon Horman <horms@...nel.org>
CC: Sunil Kovvuri Goutham <sgoutham@...vell.com>,
        Geethasowjanya Akula
	<gakula@...vell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@...vell.com>,
        Hariprasad Kelam <hkelam@...vell.com>,
        "davem@...emloft.net"
	<davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Linu Cherian
	<lcherian@...vell.com>, Jerin Jacob <jerinj@...vell.com>,
        "john.fastabend@...il.com" <john.fastabend@...il.com>,
        Bharat Bhushan
	<bbhushan2@...vell.com>,
        "hawk@...nel.org" <hawk@...nel.org>,
        "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
        "ast@...nel.org"
	<ast@...nel.org>,
        "daniel@...earbox.net" <daniel@...earbox.net>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>
Subject: RE: [EXTERNAL] Re: [net-next PATCH v2 3/6] octeontx2-pf: Add AF_XDP
 zero copy support for rx side

Hi Simon,

>> @@ -572,20 +575,31 @@ int otx2_napi_handler(struct napi_struct *napi,
>int budget)
>>  		if (pfvf->flags & OTX2_FLAG_ADPTV_INT_COAL_ENABLED)
>>  			otx2_adjust_adaptive_coalese(pfvf, cq_poll);
>>
>> +		if (likely(cq))
>> +			pool = &pfvf->qset.pool[cq->cq_idx];
>> +
>
>Hi Suman,
>
>FWIIW, Smatch is still concerned that cq may be used uninitialised here.
>
[Suman] ack
>...
>
>> @@ -1429,13 +1447,24 @@ static bool otx2_xdp_rcv_pkt_handler(struct
>otx2_nic *pfvf,
>>  	unsigned char *hard_start;
>>  	struct otx2_pool *pool;
>>  	int qidx = cq->cq_idx;
>> -	struct xdp_buff xdp;
>> +	struct xdp_buff xdp, *xsk_buff = NULL;
>>  	struct page *page;
>>  	u64 iova, pa;
>>  	u32 act;
>>  	int err;
>
>Please consider preserving reverse xmas tree order - longest line to
>shortest - for local variable declarations.
[Suman] ack
>
>...