linux-kernel - Re: [V1,03/12] media: mediatek: jpeg: add jpeg compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cc1dff25-2de2-40fe-bf3d-cc9e8f735eeb@collabora.com>
Date: Fri, 10 Jan 2025 10:46:51 +0100
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: "kyrie.wu" <kyrie.wu@...iatek.com>,
 Hans Verkuil <hverkuil-cisco@...all.nl>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, Rob Herring
 <robh+dt@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>,
 Tzung-Bi Shih <tzungbi@...omium.org>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Bin Liu <bin.liu@...iatek.com>,
 kyrie wu <kyrie.wu@...iatek.corp-partner.google.com>,
 linux-media@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-mediatek@...ts.infradead.org
Subject: Re: [V1,03/12] media: mediatek: jpeg: add jpeg compatible

Il 09/01/25 14:35, kyrie.wu ha scritto:
> Add jpeg dec and enc compatible for mt8196
> 
> Signed-off-by: kyrie.wu <kyrie.wu@...iatek.com>
> ---
>   drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c   | 8 ++++++++
>   drivers/media/platform/mediatek/jpeg/mtk_jpeg_dec_hw.c | 3 +++
>   drivers/media/platform/mediatek/jpeg/mtk_jpeg_enc_hw.c | 3 +++
>   3 files changed, 14 insertions(+)
> 
> diff --git a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c
> index 9517ebed0701..c3ccc525d9fd 100644
> --- a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c
> +++ b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c
> @@ -1996,6 +1996,14 @@ static const struct of_device_id mtk_jpeg_match[] = {
>   		.compatible = "mediatek,mt8188-jpgdec",
>   		.data = &mtk8188_jpegdec_drvdata,
>   	},
> +	{
> +		.compatible = "mediatek,mt8196-jpgenc",
> +		.data = &mtk8195_jpegenc_drvdata,
> +	},
> +	{
> +		.compatible = "mediatek,mt8196-jpgdec",
> +		.data = &mtk8195_jpegdec_drvdata,

You're adding this with MT8195 platform data, and then you're changing it to
MT8196 specific platform data.

Just put this commit at the end of the series, at this point.

Regards,
Angelo

> +	},
>   	{},
>   };
>   
> diff --git a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_dec_hw.c b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_dec_hw.c
> index ebded06ba92d..d868e46aaf37 100644
> --- a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_dec_hw.c
> +++ b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_dec_hw.c
> @@ -45,6 +45,9 @@ static const struct of_device_id mtk_jpegdec_hw_ids[] = {
>   	{
>   		.compatible = "mediatek,mt8195-jpgdec-hw",
>   	},
> +	{
> +		.compatible = "mediatek,mt8196-jpgdec-hw",
> +	},
>   	{},
>   };
>   MODULE_DEVICE_TABLE(of, mtk_jpegdec_hw_ids);
> diff --git a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_enc_hw.c b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_enc_hw.c
> index 87fe1f324f23..ca06d4f435cd 100644
> --- a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_enc_hw.c
> +++ b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_enc_hw.c
> @@ -52,6 +52,9 @@ static const struct of_device_id mtk_jpegenc_drv_ids[] = {
>   	{
>   		.compatible = "mediatek,mt8195-jpgenc-hw",
>   	},
> +	{
> +		.compatible = "mediatek,mt8196-jpgenc-hw",
> +	},
>   	{},
>   };
>   MODULE_DEVICE_TABLE(of, mtk_jpegenc_drv_ids);