linux-kernel - Re: linux-next: build failure after merge of the rust tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72=zO_Grb-eX6SYxPrQszksgfe8Lfg35Ee49kFgBVFWRvA@mail.gmail.com>
Date: Fri, 10 Jan 2025 11:16:14 +0100
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Alice Ryhl <aliceryhl@...gle.com>, Miguel Ojeda <ojeda@...nel.org>, 
	Stephen Rothwell <sfr@...b.auug.org.au>, 
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, 
	Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: build failure after merge of the rust tree

On Fri, Jan 10, 2025 at 10:34 AM Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
>
> Can I take this as a real patch for my tree?  Or is this only an issue
> due to the trees being merged?

The issue appears when the trees are merged, i.e. the code is on its
own OK, though it is also true the code should be using the function
but the macro (even if both work), so you could take the patch as an
independent cleanup to the tree, I guess. In that case, I would clean
the 3 cases (i.e. adding `!` but not removing `kernel::`).

I can also drop a couple bits in `rust-next` and do the cleanup early
next cycle.

Context:

    15f2f9313a39 ("rust: use the `build_error!` macro, not the hidden function")
    614724e780f5 ("rust: kernel: move `build_error` hidden function to
prevent mistakes")

Thanks!

Cheers,
Miguel