linux-kernel - Re: [PATCH] arm64: dts: ti: k3-j784s4-evm:quad-port-eth-exp1: Remove duplicate hogs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b67cc247-0c96-493c-b048-315db295158a@ti.com>
Date: Fri, 10 Jan 2025 16:20:15 +0530
From: Jayesh Choudhary <j-choudhary@...com>
To: Siddharth Vadapalli <s-vadapalli@...com>
CC: <nm@...com>, <vigneshr@...com>, <kristo@...nel.org>, <robh@...nel.org>,
        <krzk+dt@...nel.org>, <conor+dt@...nel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <c-vankar@...com>
Subject: Re: [PATCH] arm64: dts: ti: k3-j784s4-evm:quad-port-eth-exp1: Remove
 duplicate hogs

Hello Siddharth,

Thank you for the review.

On 10/01/25 16:15, Siddharth Vadapalli wrote:
> On Fri, Jan 10, 2025 at 03:48:55PM +0530, Jayesh Choudhary wrote:
> 
> Hello Jayesh,
> 
> In the $subject of this patch, please use the overlay name as-is instead
> of adding the colon which splits the overlay name:
> s/k3-j784s4-evm:quad-port-eth-exp1/k3-j784s4-evm-quad-port-eth-exp1

I will fix this typo.

> 
>> The j784s4-evm board dts now has the gpio hogs for MUX2 after integration
>> of audio support.
>> Remove duplicate gpio-hogs from the overlay dtso to prevent mux probe
>> failures leading to can-phy3 deferred probe:
>> 'gpio-mux mux-controller: probe with driver gpio-mux failed with error -16'
> 
> This appears to be a fix since overlay functionality was broken since
> the commit which introduced audio support. Please add a "Fixes" tag
> to indicate this.
> 

Will add it in v2.

Warm Regards,
Jayesh

>>
>> Signed-off-by: Jayesh Choudhary <j-choudhary@...com>
> 
> With the above comments addressed,
> 
> Reviewed-by: Siddharth Vadapalli <s-vadapalli@...com>
> 
> Regards,
> Siddharth.