linux-kernel - arch/powerpc/kernel/eeh_driver.c:786: warning: expecting prototype for eeh_check_slot_presence(). Prototype was for eeh_slot_presence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202501100917.m9I062gm-lkp@intel.com>
Date: Fri, 10 Jan 2025 09:23:15 +0800
From: kernel test robot <lkp@...el.com>
To: Oliver O'Halloran <oohall@...il.com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Michael Ellerman <mpe@...erman.id.au>
Subject: arch/powerpc/kernel/eeh_driver.c:786: warning: expecting prototype
 for eeh_check_slot_presence(). Prototype was for eeh_slot_presence_check()
 instead

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   c77cd47cee041bc1664b8e5fcd23036e5aab8e2a
commit: b104af5a7687060792ca398bb86b033057afce75 powerpc/eeh: Check slot presence state in eeh_handle_normal_event()
date:   5 years ago
config: powerpc64-randconfig-002-20231105 (https://download.01.org/0day-ci/archive/20250110/202501100917.m9I062gm-lkp@intel.com/config)
compiler: powerpc64-linux-gcc (GCC) 12.4.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250110/202501100917.m9I062gm-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501100917.m9I062gm-lkp@intel.com/

All warnings (new ones prefixed by >>):

   arch/powerpc/kernel/eeh_driver.c:158: warning: Function parameter or struct member 'edev' not described in 'eeh_disable_irq'
   arch/powerpc/kernel/eeh_driver.c:158: warning: Excess function parameter 'dev' description in 'eeh_disable_irq'
   arch/powerpc/kernel/eeh_driver.c:181: warning: Function parameter or struct member 'edev' not described in 'eeh_enable_irq'
   arch/powerpc/kernel/eeh_driver.c:181: warning: Excess function parameter 'dev' description in 'eeh_enable_irq'
   arch/powerpc/kernel/eeh_driver.c:343: warning: Function parameter or struct member 'pdev' not described in 'eeh_report_error'
   arch/powerpc/kernel/eeh_driver.c:369: warning: Function parameter or struct member 'pdev' not described in 'eeh_report_mmio_enabled'
   arch/powerpc/kernel/eeh_driver.c:389: warning: Function parameter or struct member 'pdev' not described in 'eeh_report_reset'
   arch/powerpc/kernel/eeh_driver.c:435: warning: Function parameter or struct member 'pdev' not described in 'eeh_report_resume'
   arch/powerpc/kernel/eeh_driver.c:461: warning: Function parameter or struct member 'pdev' not described in 'eeh_report_failure'
>> arch/powerpc/kernel/eeh_driver.c:786: warning: expecting prototype for eeh_check_slot_presence(). Prototype was for eeh_slot_presence_check() instead


vim +786 arch/powerpc/kernel/eeh_driver.c

   772	
   773	/**
   774	 * eeh_check_slot_presence - Check if a device is still present in a slot
   775	 * @pdev: pci_dev to check
   776	 *
   777	 * This function may return a false positive if we can't determine the slot's
   778	 * presence state. This might happen for for PCIe slots if the PE containing
   779	 * the upstream bridge is also frozen, or the bridge is part of the same PE
   780	 * as the device.
   781	 *
   782	 * This shouldn't happen often, but you might see it if you hotplug a PCIe
   783	 * switch.
   784	 */
   785	static bool eeh_slot_presence_check(struct pci_dev *pdev)
 > 786	{
   787		const struct hotplug_slot_ops *ops;
   788		struct pci_slot *slot;
   789		u8 state;
   790		int rc;
   791	
   792		if (!pdev)
   793			return false;
   794	
   795		if (pdev->error_state == pci_channel_io_perm_failure)
   796			return false;
   797	
   798		slot = pdev->slot;
   799		if (!slot || !slot->hotplug)
   800			return true;
   801	
   802		ops = slot->hotplug->ops;
   803		if (!ops || !ops->get_adapter_status)
   804			return true;
   805	
   806		rc = ops->get_adapter_status(slot->hotplug, &state);
   807		if (rc)
   808			return true;
   809	
   810		return !!state;
   811	}
   812	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki