linux-kernel - Re: [PATCH 01/16] selftests/mm: remove argc and argv unused parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20250109161246.f43a69773b5459e5200d3f45@linux-foundation.org>
Date: Thu, 9 Jan 2025 16:12:46 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: Kees Cook <kees@...nel.org>
Cc: Muhammad Usama Anjum <Usama.Anjum@...labora.com>, Andy Lutomirski
 <luto@...capital.net>, Will Drewry <wad@...omium.org>, Shuah Khan
 <shuah@...nel.org>, Jérôme Glisse
 <jglisse@...hat.com>, linux-kselftest@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-mm@...ck.org, kernel@...labora.com
Subject: Re: [PATCH 01/16] selftests/mm: remove argc and argv unused
 parameters

On Thu, 9 Jan 2025 09:50:45 -0800 Kees Cook <kees@...nel.org> wrote:

> On Thu, Jan 09, 2025 at 10:48:52PM +0500, Muhammad Usama Anjum wrote:
> > For the all other case, why should we keep argv/argc and mark them unused
> > as well when they aren't being used?
> 
> I'm fine either way, but my personal code style instinct is to keep the
> "standard" main declaration with argc/argv present. But it's mostly
> aesthetic.
> 
> And if you think use of kselftest.h isn't universal, then perhaps we can
> avoid the macro, but it does seem nicer and more "normal" feeling for
> the rest of kernel development.
> 

Agreed.  __attribute__((unused)) is a bit of a mouthful and isn't what
the kernel developer's eye expects to see.