linux-kernel - Re: [PATCH] miscdevice: rust: use build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAH5fLgjeFH73DOmihQdBLnB8tDfTsQHEi=4nzVG=isifvOZ7gw@mail.gmail.com>
Date: Fri, 10 Jan 2025 13:32:00 +0100
From: Alice Ryhl <aliceryhl@...gle.com>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>, linux-kernel@...r.kernel.org, 
	linux-next@...r.kernel.org, ojeda@...nel.org, sfr@...b.auug.org.au
Subject: Re: [PATCH] miscdevice: rust: use build_error! macro instead of function

On Fri, Jan 10, 2025 at 1:23 PM Greg KH <gregkh@...uxfoundation.org> wrote:
>
> On Fri, Jan 10, 2025 at 11:38:10AM +0100, Miguel Ojeda wrote:
> > On Fri, Jan 10, 2025 at 11:15 AM Alice Ryhl <aliceryhl@...gle.com> wrote:
> > >
> > > The function called build_error is an implementation detail of the macro
> > > of the same name. Thus, update miscdevice to use the macro rather than
> > > the function. See [1] for more information on this.
> > >
> > > This use the macro with the kernel:: prefix as it has not yet been added
> > > to the prelude.
> >
> > Typo: "These"
> >
> > Acked-by: Miguel Ojeda <ojeda@...nel.org>
>
> And I'll add a Reported-by: line when I apply this in a few minutes,
> thanks!

Good call, thanks!