linux-kernel - RE: [PATCH] arm64: dts: socfpga: stratix10_swvp: remove invalid sysmgr properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BL3PR11MB6532C0F5634AC46C04B78733A21C2@BL3PR11MB6532.namprd11.prod.outlook.com>
Date: Fri, 10 Jan 2025 12:39:46 +0000
From: "Rabara, Niravkumar L" <niravkumar.l.rabara@...el.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, Dinh Nguyen <dinguyen@...nel.org>,
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
CC: lkp <lkp@...el.com>
Subject: RE: [PATCH] arm64: dts: socfpga: stratix10_swvp: remove invalid
 sysmgr properties



> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@...nel.org>
> Sent: Friday, 10 January, 2025 7:37 PM
> To: Rabara, Niravkumar L <niravkumar.l.rabara@...el.com>; Dinh Nguyen
> <dinguyen@...nel.org>; Rob Herring <robh@...nel.org>; Krzysztof Kozlowski
> <krzk+dt@...nel.org>; Conor Dooley <conor+dt@...nel.org>;
> devicetree@...r.kernel.org; linux-kernel@...r.kernel.org
> Cc: lkp <lkp@...el.com>
> Subject: Re: [PATCH] arm64: dts: socfpga: stratix10_swvp: remove invalid
> sysmgr properties
> 
> On 10/01/2025 12:26, niravkumar.l.rabara@...el.com wrote:
> > From: Niravkumar L Rabara <niravkumar.l.rabara@...el.com>
> >
> > Removed invalid sys-mgr properties for stratix10 and fixed
> 
> "Remove"
> 
> > dtbs_check warnings like:
> >
> > socfpga_stratix10_swvp.dtb: sysmgr@...12000: cpu1-start-addr: False
> > schema does not allow 4291846704 from schema $id:
> > http://devicetree.org/schemas/soc/altera/altr,sys-mgr.yaml#
> > socfpga_stratix10_swvp.dtb: sysmgr@...12000: 'interrupts' does not
> > match any of the regexes: 'pinctrl-[0-9]+'
> > from schema $id:
> > http://devicetree.org/schemas/soc/altera/altr,sys-mgr.yaml#
> 
> This message is not readable. Don't wrap it.

Will fix this in v2. 
> 
> >
> > Reported-by: kernel test robot <lkp@...el.com>
> > Closes:
> > https://lore.kernel.org/oe-kbuild-all/202501091748.L2W2RwE5-lkp@intel.
> > com/
> > Signed-off-by: Niravkumar L Rabara <niravkumar.l.rabara@...el.com>
> > ---
> >  arch/arm64/boot/dts/altera/socfpga_stratix10_swvp.dts | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10_swvp.dts
> > b/arch/arm64/boot/dts/altera/socfpga_stratix10_swvp.dts
> > index 0d837d3e65a5..fce1dc2ebad0 100644
> > --- a/arch/arm64/boot/dts/altera/socfpga_stratix10_swvp.dts
> > +++ b/arch/arm64/boot/dts/altera/socfpga_stratix10_swvp.dts
> > @@ -110,6 +110,4 @@ &rst {
> >
> >  &sysmgr {
> >  	reg = <0xffd12000 0x1000>;
> > -	interrupts = <0x0 0x10 0x4>;
> 
> Is this correct? Some background would be useful.

stratix10_swvp.dts is for legacy Stratix10 SW Virtual Platform.
The socfpga system manager dt binding does not include "interrupt" property
and the existing socfpga board files does not use it for sysmgr.
(e.g. Cyclon5/Arria10/stratix10/Agilex)

Socfpga system manager drivers (altera-sysmgr.c/socfpga.c) also does not use
interrupt property.
The stratix10_swvp.dts has this property since beginning(unused) but 
dtbs_check warning only appeared recently when I convert system manger binding
from txt to yaml.

Thanks,
Nirav