linux-kernel - Re: [PATCH 03/12] dt-bindings: display: mediatek: add EXDMA yaml for MT8196

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <abadfae8-56f7-499c-83ff-7d79e3fe1f52@kernel.org>
Date: Fri, 10 Jan 2025 14:01:11 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: "paul-pl.chen" <paul-pl.chen@...iatek.com>, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, chunkuang.hu@...nel.org,
 angelogioacchino.delregno@...labora.com
Cc: matthias.bgg@...il.com, p.zabel@...gutronix.de,
 jason-jh.lin@...iatek.com, nancy.lin@...iatek.com, singo.chang@...iatek.com,
 xiandong.wang@...iatek.com, sirius.wang@...iatek.com,
 sunny.shen@...iatek.com, fshao@...omium.org, treapking@...omium.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 dri-devel@...ts.freedesktop.org, linux-mediatek@...ts.infradead.org,
 linux-arm-kernel@...ts.infradead.org,
 Project_Global_Chrome_Upstream_Group@...iatek.com
Subject: Re: [PATCH 03/12] dt-bindings: display: mediatek: add EXDMA yaml for
 MT8196

On 10/01/2025 13:33, paul-pl.chen wrote:
> From: "Paul-pl.Chen" <paul-pl.chen@...iatek.com>
> 
> Add mediatek,exdma.yaml to support EXDMA for MT8196.
> 
> Signed-off-by: Paul-pl.Chen <paul-pl.chen@...iatek.com>
> ---
> The header used in examples:
> #include <dt-bindings/clock/mt8196-clk.h>
> #include <dt-bindings/power/mt8196-power.h>
> are not upstreamed yet.

Which makes this untestable and unmergeable.

This cannot be accepted. Fix your dependencies or decouple from them.

> It will be sent by related owner soon.

Still this won't build and won't be possible to apply.

> ---
>  .../display/mediatek/mediatek,exdma.yaml      | 77 +++++++++++++++++++
>  1 file changed, 77 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,exdma.yaml
> 
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,exdma.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,exdma.yaml
> new file mode 100644
> index 000000000000..385f5549dfaa
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,exdma.yaml

Filename matching compatible.

Why is this in display? DMA goes to dma.

> @@ -0,0 +1,77 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/mediatek/mediatek,exdma.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MediaTek EXDMA
> +
> +maintainers:
> +  - Chun-Kuang Hu <chunkuang.hu@...nel.org>
> +  - Philipp Zabel <p.zabel@...gutronix.de>
> +
> +description:
> +  The MediaTek display overlap extended DMA engine, namely OVL_EXDMA or EXDMA,
> +  primarily functions as a DMA engine for reading data from DRAM with various
> +  DRAM footprints and data formats. For input sources in certain color formats
> +  and color domains, OVL_EXDMA also includes a color transfer function
> +  to process pixels into a consistent color domain.
> +

Missing ref to dma schemas.

> +properties:
> +  compatible:
> +    const: mediatek,mt8196-exdma
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    items:
> +      - description: EXDMA Clock
> +
> +  power-domains:
> +    maxItems: 1
> +
> +  mediatek,larb:
> +    $ref: /schemas/types.yaml#/definitions/phandle-array

Why array? And isn't the property named mediatek,larbs?


> +    maxItems: 1
> +    items:
> +      maxItems: 1
> +    description: |
> +      A phandle to the local arbiters node in the current SoCs.
> +      Refer to bindings/memory-controllers/mediatek,smi-larb.yaml.
> +
> +  iommus:
> +    maxItems: 1
> +
> +  '#dma-cells':
> +    const: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - power-domains
> +  - mediatek,larb
> +  - iommus
Best regards,
Krzysztof