linux-kernel - Re: [PATCH] mtd: hyperbus: Use of_property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ba62ddea-c905-4969-997d-545b3adc186b@linaro.org>
Date: Fri, 10 Jan 2025 13:13:48 +0000
From: Tudor Ambarus <tudor.ambarus@...aro.org>
To: "Rob Herring (Arm)" <robh@...nel.org>,
 Vignesh Raghavendra <vigneshr@...com>,
 Miquel Raynal <miquel.raynal@...tlin.com>,
 Richard Weinberger <richard@....at>
Cc: linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mtd: hyperbus: Use of_property_present() for non-boolean
 properties



On 1/9/25 6:21 PM, Rob Herring (Arm) wrote:
> The use of of_property_read_bool() for non-boolean properties is
> deprecated in favor of of_property_present() when testing for property
> presence.
> 
> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>

Reviewed-by: Tudor Ambarus <tudor.ambarus@...aro.org>

> ---
>  drivers/mtd/hyperbus/hbmc-am654.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/hyperbus/hbmc-am654.c b/drivers/mtd/hyperbus/hbmc-am654.c
> index 217f4e69233f..60bdce4391cd 100644
> --- a/drivers/mtd/hyperbus/hbmc-am654.c
> +++ b/drivers/mtd/hyperbus/hbmc-am654.c
> @@ -176,7 +176,7 @@ static int am654_hbmc_probe(struct platform_device *pdev)
>  	if (ret)
>  		return ret;
>  
> -	if (of_property_read_bool(dev->of_node, "mux-controls")) {
> +	if (of_property_present(dev->of_node, "mux-controls")) {
>  		struct mux_control *control = devm_mux_control_get(dev, NULL);
>  
>  		if (IS_ERR(control))