linux-kernel - Re: [PATCH 2/3] kbuild: rust: apply `CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878qrig5f5.fsf@kernel.org>
Date: Fri, 10 Jan 2025 14:33:02 +0100
From: Andreas Hindborg <a.hindborg@...nel.org>
To: Masahiro Yamada <masahiroy@...nel.org>
Cc: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>,  Miguel Ojeda
 <ojeda@...nel.org>,  Wedson Almeida Filho <wedsonaf@...il.com>,  Alex
 Gaynor <alex.gaynor@...il.com>,  Nathan Chancellor <nathan@...nel.org>,
  Nicolas Schier <nicolas@...sle.eu>,  Boqun Feng <boqun.feng@...il.com>,
  Gary Guo <gary@...yguo.net>,  Björn Roy Baron
 <bjorn3_gh@...tonmail.com>,
  Benno Lossin <benno.lossin@...ton.me>,  Andreas Hindborg
 <a.hindborg@...sung.com>,  Alice Ryhl <aliceryhl@...gle.com>,
  linux-kbuild@...r.kernel.org,  rust-for-linux@...r.kernel.org,
  linux-kernel@...r.kernel.org,  patches@...ts.linux.dev
Subject: Re: [PATCH 2/3] kbuild: rust: apply `CONFIG_WERROR` to all Rust
 targets

Masahiro Yamada <masahiroy@...nel.org> writes:

> On Wed, May 22, 2024 at 7:52 PM Miguel Ojeda
> <miguel.ojeda.sandonis@...il.com> wrote:
>>
>> On Wed, May 22, 2024 at 12:14 PM Masahiro Yamada <masahiroy@...nel.org> wrote:
>> >
>> > What does "everything else" mean exactly?
>>
>> Everything but the host programs. Or as many targets as possible, if
>> you think there are other cases that we should avoid.
>
>
> You can do this if rebuilding makes sense
> when any CONFIG option is changed.

Not having the ability to make builds fail when clippy or rustdoc is
issuing warnings is a big problem. I would very much like to have the
option to make builds fail when these targets give warnings.

@Miguel: Should I look into exempting host programs, or do you already
have an idea of how to implement?


Regarding host programs, it would be nice to set werror for those. How
does C do this? Is W=e enough?


Best regards,
Andreas Hindborg