linux-kernel - Re: [PATCH 2/2] usb: typec: cros-ec-ucsi: Mark cros_ucsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALwA+NYD_0JqAByT73j2_nW3jJfb1RdBdSnQ-xAQV8HYf=LGSg@mail.gmail.com>
Date: Fri, 10 Jan 2025 14:47:39 +0100
From: Łukasz Bartosik <ukaszb@...omium.org>
To: Stephen Boyd <swboyd@...omium.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-kernel@...r.kernel.org, 
	patches@...ts.linux.dev, Benson Leung <bleung@...omium.org>, 
	chrome-platform@...ts.linux.dev, linux-usb@...r.kernel.org, 
	Pavan Holla <pholla@...omium.org>, Abhishek Pandit-Subedi <abhishekpandit@...omium.org>
Subject: Re: [PATCH 2/2] usb: typec: cros-ec-ucsi: Mark cros_ucsi_ops static/const

On Thu, Jan 9, 2025 at 11:07 PM Stephen Boyd <swboyd@...omium.org> wrote:
>
> This structure isn't used outside this file and can be marked const so
> that it gets moved to read-only memory.
>
> Cc: Pavan Holla <pholla@...omium.org>
> Cc: Abhishek Pandit-Subedi <abhishekpandit@...omium.org>
> Cc: Łukasz Bartosik <ukaszb@...omium.org>
> Signed-off-by: Stephen Boyd <swboyd@...omium.org>

Reviewed-by: Łukasz Bartosik <ukaszb@...omium.org>

> ---
>  drivers/usb/typec/ucsi/cros_ec_ucsi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/ucsi/cros_ec_ucsi.c b/drivers/usb/typec/ucsi/cros_ec_ucsi.c
> index 75646a8d55be..c605c8616726 100644
> --- a/drivers/usb/typec/ucsi/cros_ec_ucsi.c
> +++ b/drivers/usb/typec/ucsi/cros_ec_ucsi.c
> @@ -133,7 +133,7 @@ static int cros_ucsi_sync_control(struct ucsi *ucsi, u64 cmd)
>         return ret;
>  }
>
> -struct ucsi_operations cros_ucsi_ops = {
> +static const struct ucsi_operations cros_ucsi_ops = {
>         .read_version = cros_ucsi_read_version,
>         .read_cci = cros_ucsi_read_cci,
>         .read_message_in = cros_ucsi_read_message_in,
> --
> https://chromeos.dev
>