linux-kernel - Re: [PATCH 10/12] dt-bindings: phy: allwinner: add v853 usb phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <39444068-0996-4699-b1f9-d34c911dbd6a@kernel.org>
Date: Fri, 10 Jan 2025 14:53:20 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Andras Szemzo <szemzo.andras@...il.com>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd
 <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Chen-Yu Tsai <wens@...e.org>,
 Jernej Skrabec <jernej.skrabec@...il.com>,
 Samuel Holland <samuel@...lland.org>,
 Linus Walleij <linus.walleij@...aro.org>,
 Philipp Zabel <p.zabel@...gutronix.de>, Maxime Ripard <mripard@...nel.org>
Cc: Vinod Koul <vkoul@...nel.org>, Kishon Vijay Abraham I
 <kishon@...nel.org>, Ulf Hansson <ulf.hansson@...aro.org>,
 Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt
 <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>,
 Uwe Kleine-König <u.kleine-koenig@...libre.com>,
 Florian Fainelli <florian.fainelli@...adcom.com>, linux-clk@...r.kernel.org,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-sunxi@...ts.linux.dev, linux-kernel@...r.kernel.org,
 linux-phy@...ts.infradead.org, linux-gpio@...r.kernel.org,
 linux-pm@...r.kernel.org, linux-riscv@...ts.infradead.org
Subject: Re: [PATCH 10/12] dt-bindings: phy: allwinner: add v853 usb phy

On 10/01/2025 13:39, Andras Szemzo wrote:
> +
> +properties:
> +  "#phy-cells":
> +    const: 1
> +
> +  compatible:
> +    const:
> +	- allwinner,sun8i-v853-usb-phy

Wrong indentation, never tested.

Compatible is always the first property.

> +
> +  reg:
> +    items:
> +      - description: PHY Control registers
> +      - description: PHY PMU0 registers
> +
> +  reg-names:
> +    items:
> +      - const: phy_ctrl
> +      - const: pmu0
> +
> +  clocks:
> +    maxItems: 1
> +    description: USB OHCI PHY bus clock

Redundant description really...

> +
> +  clock-names:
> +    const: usb0_phy

Drop clock-names, not really helpful.


> +
> +  resets:
> +    maxItems: 1
> +    description: USB OHCI reset
> +
> +  reset-names:
> +    const: usb0_reset

Drop names, also not really helping.

> +
> +  usb0_id_det-gpios:

There are no properties with underscores.

I don't get why you are using "usb0" prefix. Document all pins, so
"usb1" as well, assuming it exists.

It anyway looks questionable - aren't these properties of connector?


> +    maxItems: 1
> +    description: GPIO to the USB OTG ID pin
> +
> +  usb0_vbus_det-gpios:
> +    maxItems: 1
> +    description: GPIO to the USB OTG VBUS detect pin
> +
> +  usb0_vbus_power-supply:
> +    description: Power supply to detect the USB OTG VBUS
> +
> +  usb0_vbus-supply:
> +    description: Regulator controlling USB OTG VBUS

Regulator and power supply are here synonyms, so I don't understand
these two properties.

> +
> +required:
> +  - "#phy-cells"
> +  - compatible
> +  - clocks
> +  - clock-names
> +  - reg
> +  - reg-names
> +  - resets
> +  - reset-names
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +    #include <dt-bindings/clock/sun8i-v853-ccu.h>
> +    #include <dt-bindings/reset/sun8i-v853-ccu.h>
> +
> +    usbphy: phy@...0400 {
> +        #phy-cells = <1>;
Please follow DTS coding style.

Best regards,
Krzysztof