linux-kernel - Re: [PATCH 06/12] dt-bindings: clk: sunxi-ng: add V853 CCU clock/reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <de280eed-bcc8-4802-9734-5e95ad1f6611@kernel.org>
Date: Fri, 10 Jan 2025 14:56:38 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Andras Szemzo <szemzo.andras@...il.com>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd
 <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Chen-Yu Tsai <wens@...e.org>,
 Jernej Skrabec <jernej.skrabec@...il.com>,
 Samuel Holland <samuel@...lland.org>,
 Linus Walleij <linus.walleij@...aro.org>,
 Philipp Zabel <p.zabel@...gutronix.de>, Maxime Ripard <mripard@...nel.org>
Cc: Vinod Koul <vkoul@...nel.org>, Kishon Vijay Abraham I
 <kishon@...nel.org>, Ulf Hansson <ulf.hansson@...aro.org>,
 Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt
 <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>,
 Uwe Kleine-König <u.kleine-koenig@...libre.com>,
 Florian Fainelli <florian.fainelli@...adcom.com>, linux-clk@...r.kernel.org,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-sunxi@...ts.linux.dev, linux-kernel@...r.kernel.org,
 linux-phy@...ts.infradead.org, linux-gpio@...r.kernel.org,
 linux-pm@...r.kernel.org, linux-riscv@...ts.infradead.org
Subject: Re: [PATCH 06/12] dt-bindings: clk: sunxi-ng: add V853 CCU
 clock/reset

On 10/01/2025 13:39, Andras Szemzo wrote:
> As the device tree needs the clock/reset indices, add them to DT binding
> headers.
> 
> Signed-off-by: Andras Szemzo <szemzo.andras@...il.com>

That's never a separate commit from the binding.


...

> --- /dev/null
> +++ b/include/dt-bindings/clock/sun8i-v853-r-ccu.h
> @@ -0,0 +1,16 @@
> +/* SPDX-License-Identifier: (GPL-2.0+ OR MIT) */
> +/* Copyright(c) 2020 - 2023 Allwinner Technology Co.,Ltd. All rights reserved.
> + *
> + * Copyright (C) 2023 rengaomin@...winnertech.com
> + */
> +#ifndef _DT_BINDINGS_CLK_SUN8I_V85X_R_CCU_H_
> +#define _DT_BINDINGS_CLK_SUN8I_V85X_R_CCU_H_
> +
> +#define CLK_R_TWD		0
> +#define CLK_R_PPU		1
> +#define CLK_R_RTC		2
> +#define CLK_R_CPUCFG		3
> +
> +#define CLK_R_MAX_NO		(CLK_R_CPUCFG + 1)

Nope, drop. Not a binding.

> +
> +#endif
> diff --git a/include/dt-bindings/reset/sun8i-v853-ccu.h b/include/dt-bindings/reset/sun8i-v853-ccu.h
> new file mode 100644
> index 000000000000..89d94fcbdb55
> --- /dev/null
> +++ b/include/dt-bindings/reset/sun8i-v853-ccu.h
> @@ -0,0 +1,62 @@
> +/* SPDX-License-Identifier: (GPL-2.0+ OR MIT) */

Odd license. Did you copy the file with such license from the downstream?


Best regards,
Krzysztof