linux-kernel - Re: [PATCH v13 1/1] mctp pcc: Implement MCTP over PCC Transport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250110175028.528eeada@kernel.org>
Date: Fri, 10 Jan 2025 17:50:28 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: admiyo@...amperecomputing.com
Cc: Jeremy Kerr <jk@...econstruct.com.au>, Matt Johnston
 <matt@...econstruct.com.au>, Andrew Lunn <andrew+netdev@...n.ch>, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo
 Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, Sudeep Holla <sudeep.holla@....com>, Jonathan
 Cameron <Jonathan.Cameron@...wei.com>, Huisong Li <lihuisong@...wei.com>
Subject: Re: [PATCH v13 1/1] mctp pcc: Implement MCTP over PCC Transport

On Tue,  7 Jan 2025 12:27:33 -0500 admiyo@...amperecomputing.com wrote:
> +	//inbox initialization
> +	snprintf(name, sizeof(name), "mctpipcc%d", context.inbox_index);
> +	ndev = alloc_netdev(sizeof(struct mctp_pcc_ndev), name, NET_NAME_ENUM,
> +			    mctp_pcc_setup);
> +	if (!ndev)
> +		return -ENOMEM;
> +
> +	mctp_pcc_ndev = netdev_priv(ndev);
> +	rc = devm_add_action_or_reset(dev, mctp_cleanup_netdev, ndev);
> +	if (rc)
> +		goto cleanup_netdev;

I think this needs to move down, AFAICT mctp_cleanup_netdev calls
unregister and unregistering a netdev which was never successfully
registered is not supported.
-- 
pw-bot: cr