linux-kernel - Re: [PATCH net v4] net: ethernet: sunplus: Switch to ndo_eth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250110175737.7535f4e7@kernel.org>
Date: Fri, 10 Jan 2025 17:57:37 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Yeking@...54.com
Cc: netdev@...r.kernel.org, Wells Lu <wellslutw@...il.com>, Andrew Lunn
 <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Jason
 Gunthorpe <jgg@...pe.ca>, Arnd Bergmann <arnd@...db.de>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v4] net: ethernet: sunplus: Switch to ndo_eth_ioctl

On Fri, 10 Jan 2025 13:29:21 +0000 Yeking@...54.com wrote:
> Fixes: fd3040b9394c ("net: ethernet: Add driver for Sunplus SP7021")
> Fixes: a76053707dbf ("dev_ioctl: split out ndo_eth_ioctl")

I see your point with the ordering of the commits, please drop 
the second Fixes tag, then :) I'd slightly modify your commit 
message to make this clearer:

The device ioctl handler no longer calls ndo_do_ioctl, but calls
ndo_eth_ioctl to handle mii ioctls. However, even though sunplus
was introduced after commit a76053707dbf ("dev_ioctl: split out 
ndo_eth_ioctl"), it still tried to use ndo_do_ioctl.
Switch to ndo_eth_ioctl. (found by code inspection)

Fixes: fd3040b9394c ("net: ethernet: Add driver for Sunplus SP7021")
-- 
pw-bot: cr