lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <202501111127.8w266r3J-lkp@intel.com>
Date: Sat, 11 Jan 2025 12:02:28 +0800
From: kernel test robot <lkp@...el.com>
To: Oliver O'Halloran <oohall@...il.com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Michael Ellerman <mpe@...erman.id.au>
Subject: arch/powerpc/kernel/eeh_pe.c:261: warning: Function parameter or
 struct member 'pe' not described in '__eeh_pe_get'

Hi Oliver,

FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   77a903cd8e5a91d120ee014c8f8eae74d6c5d0f6
commit: 35d64734b64315f2c5716c5a0a380ed1ba8fbe4a powerpc/eeh: Clean up PE addressing
date:   4 years, 3 months ago
config: powerpc64-randconfig-002-20231105 (https://download.01.org/0day-ci/archive/20250111/202501111127.8w266r3J-lkp@intel.com/config)
compiler: powerpc64-linux-gcc (GCC) 12.4.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250111/202501111127.8w266r3J-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501111127.8w266r3J-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> arch/powerpc/kernel/eeh_pe.c:261: warning: Function parameter or struct member 'pe' not described in '__eeh_pe_get'
>> arch/powerpc/kernel/eeh_pe.c:261: warning: Function parameter or struct member 'flag' not described in '__eeh_pe_get'
   arch/powerpc/kernel/eeh_pe.c:516: warning: Function parameter or struct member 'root' not described in 'eeh_pe_state_mark'
   arch/powerpc/kernel/eeh_pe.c:516: warning: Function parameter or struct member 'state' not described in 'eeh_pe_state_mark'
   arch/powerpc/kernel/eeh_pe.c:516: warning: Excess function parameter 'pe' description in 'eeh_pe_state_mark'
   arch/powerpc/kernel/eeh_pe.c:534: warning: Function parameter or struct member 'root' not described in 'eeh_pe_mark_isolated'
   arch/powerpc/kernel/eeh_pe.c:534: warning: Excess function parameter 'pe' description in 'eeh_pe_mark_isolated'
   arch/powerpc/kernel/eeh_pe.c:567: warning: Function parameter or struct member 'mode' not described in 'eeh_pe_dev_mode_mark'
   arch/powerpc/kernel/eeh_pe.c:567: warning: expecting prototype for eeh_pe_dev_state_mark(). Prototype was for eeh_pe_dev_mode_mark() instead
   arch/powerpc/kernel/eeh_pe.c:582: warning: Function parameter or struct member 'root' not described in 'eeh_pe_state_clear'
   arch/powerpc/kernel/eeh_pe.c:582: warning: Excess function parameter 'data' description in 'eeh_pe_state_clear'
   arch/powerpc/kernel/eeh_pe.c:774: warning: Function parameter or struct member 'edev' not described in 'eeh_restore_one_device_bars'
   arch/powerpc/kernel/eeh_pe.c:774: warning: Excess function parameter 'data' description in 'eeh_restore_one_device_bars'

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for HOTPLUG_PCI_POWERNV
   Depends on [n]: PCI [=y] && HOTPLUG_PCI [=n] && PPC_POWERNV [=y] && EEH [=y]
   Selected by [y]:
   - OCXL [=y] && PPC_POWERNV [=y] && PCI [=y] && EEH [=y] && PPC_XIVE_NATIVE [=y]


vim +261 arch/powerpc/kernel/eeh_pe.c

9e6d2cf65e3dba arch/powerpc/platforms/pseries/eeh_pe.c Gavin Shan        2012-09-07  251  
22f4ab123f10e1 arch/powerpc/platforms/pseries/eeh_pe.c Gavin Shan        2012-09-07  252  /**
22f4ab123f10e1 arch/powerpc/platforms/pseries/eeh_pe.c Gavin Shan        2012-09-07  253   * __eeh_pe_get - Check the PE address
22f4ab123f10e1 arch/powerpc/platforms/pseries/eeh_pe.c Gavin Shan        2012-09-07  254   *
22f4ab123f10e1 arch/powerpc/platforms/pseries/eeh_pe.c Gavin Shan        2012-09-07  255   * For one particular PE, it can be identified by PE address
22f4ab123f10e1 arch/powerpc/platforms/pseries/eeh_pe.c Gavin Shan        2012-09-07  256   * or tranditional BDF address. BDF address is composed of
22f4ab123f10e1 arch/powerpc/platforms/pseries/eeh_pe.c Gavin Shan        2012-09-07  257   * Bus/Device/Function number. The extra data referred by flag
22f4ab123f10e1 arch/powerpc/platforms/pseries/eeh_pe.c Gavin Shan        2012-09-07  258   * indicates which type of address should be used.
22f4ab123f10e1 arch/powerpc/platforms/pseries/eeh_pe.c Gavin Shan        2012-09-07  259   */
d6c4932fbf2421 arch/powerpc/kernel/eeh_pe.c            Sam Bobroff       2018-05-25  260  static void *__eeh_pe_get(struct eeh_pe *pe, void *flag)
22f4ab123f10e1 arch/powerpc/platforms/pseries/eeh_pe.c Gavin Shan        2012-09-07 @261  {
35d64734b64315 arch/powerpc/kernel/eeh_pe.c            Oliver O'Halloran 2020-09-18  262  	int *target_pe = flag;
22f4ab123f10e1 arch/powerpc/platforms/pseries/eeh_pe.c Gavin Shan        2012-09-07  263  
35d64734b64315 arch/powerpc/kernel/eeh_pe.c            Oliver O'Halloran 2020-09-18  264  	/* PHB PEs are special and should be ignored */
5efc3ad7325d81 arch/powerpc/platforms/pseries/eeh_pe.c Gavin Shan        2012-09-11  265  	if (pe->type & EEH_PE_PHB)
22f4ab123f10e1 arch/powerpc/platforms/pseries/eeh_pe.c Gavin Shan        2012-09-07  266  		return NULL;
22f4ab123f10e1 arch/powerpc/platforms/pseries/eeh_pe.c Gavin Shan        2012-09-07  267  
35d64734b64315 arch/powerpc/kernel/eeh_pe.c            Oliver O'Halloran 2020-09-18  268  	if (*target_pe == pe->addr)
22f4ab123f10e1 arch/powerpc/platforms/pseries/eeh_pe.c Gavin Shan        2012-09-07  269  		return pe;
22f4ab123f10e1 arch/powerpc/platforms/pseries/eeh_pe.c Gavin Shan        2012-09-07  270  
22f4ab123f10e1 arch/powerpc/platforms/pseries/eeh_pe.c Gavin Shan        2012-09-07  271  	return NULL;
22f4ab123f10e1 arch/powerpc/platforms/pseries/eeh_pe.c Gavin Shan        2012-09-07  272  }
22f4ab123f10e1 arch/powerpc/platforms/pseries/eeh_pe.c Gavin Shan        2012-09-07  273  

:::::: The code at line 261 was first introduced by commit
:::::: 22f4ab123f10e1862579785c73d9e60fa24afd4f powerpc/eeh: Search PE based on requirement

:::::: TO: Gavin Shan <shangw@...ux.vnet.ibm.com>
:::::: CC: Benjamin Herrenschmidt <benh@...nel.crashing.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ