linux-kernel - RE: [PATCH] arm64: dts: socfpga: stratix10_swvp: remove invalid sysmgr properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BL3PR11MB6532341D8AA6F2DAF55F6AC6A21D2@BL3PR11MB6532.namprd11.prod.outlook.com>
Date: Sat, 11 Jan 2025 05:47:46 +0000
From: "Rabara, Niravkumar L" <niravkumar.l.rabara@...el.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, Dinh Nguyen <dinguyen@...nel.org>,
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
CC: lkp <lkp@...el.com>
Subject: RE: [PATCH] arm64: dts: socfpga: stratix10_swvp: remove invalid
 sysmgr properties



> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@...nel.org>
> Sent: Friday, 10 January, 2025 8:57 PM
> To: Rabara, Niravkumar L <niravkumar.l.rabara@...el.com>; Dinh Nguyen
> <dinguyen@...nel.org>; Rob Herring <robh@...nel.org>; Krzysztof Kozlowski
> <krzk+dt@...nel.org>; Conor Dooley <conor+dt@...nel.org>;
> devicetree@...r.kernel.org; linux-kernel@...r.kernel.org
> Cc: lkp <lkp@...el.com>
> Subject: Re: [PATCH] arm64: dts: socfpga: stratix10_swvp: remove invalid sysmgr
> properties
> 
> On 10/01/2025 13:39, Rabara, Niravkumar L wrote:
> >>>  &sysmgr {
> >>>  	reg = <0xffd12000 0x1000>;
> >>> -	interrupts = <0x0 0x10 0x4>;
> >>
> >> Is this correct? Some background would be useful.
> >
> > stratix10_swvp.dts is for legacy Stratix10 SW Virtual Platform.
> > The socfpga system manager dt binding does not include "interrupt"
> > property and the existing socfpga board files does not use it for sysmgr.
> > (e.g. Cyclon5/Arria10/stratix10/Agilex)
> >
> > Socfpga system manager drivers (altera-sysmgr.c/socfpga.c) also does
> > not use interrupt property.
> > The stratix10_swvp.dts has this property since beginning(unused) but
> > dtbs_check warning only appeared recently when I convert system manger
> > binding from txt to yaml.
> All this I deduced from the change, but it still not answer about hardware.

System Manager hardware block contains control and status registers for
some IPs like EMAC, FPGA to SOC bridge, ECC, USB etc.
e.g 
For EMAC, to configure/check PHY interface selection for GMII/RGMII/RMII.
For ECC, interrupt mask and status register for USB, Onchip RAM, EMAC etc. 
Scratch pad registers to pass handoff data from FPGA Secure device manager
to bootloader. 

There is a global system manager interrupt(System Manger -> GIC -> CPU)
to serve single/double bit ECC interrupt to CPU. 
Since its dedicated for ECC usage in HW it is not included in system manager
dt bindings instead it’s a part of ECC manager bindings.

Thanks,
Nirav