| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202501111455.VMWXk7sN-lkp@intel.com>
Date: Sat, 11 Jan 2025 14:51:18 +0800
From: kernel test robot <lkp@...el.com>
To: Philipp Stanner <phasta@...nel.org>,
Damien Le Moal <dlemoal@...nel.org>,
Niklas Cassel <cassel@...nel.org>,
Mikael Pettersson <mikpelinux@...il.com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-ide@...r.kernel.org,
linux-kernel@...r.kernel.org, Philipp Stanner <pstanner@...hat.com>
Subject: Re: [PATCH] ata: Replace deprecated PCI functions
Hi Philipp,
kernel test robot noticed the following build errors:
[auto build test ERROR on linus/master]
[also build test ERROR on v6.13-rc6 next-20250110]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Philipp-Stanner/ata-Replace-deprecated-PCI-functions/20250103-004040
base: linus/master
patch link: https://lore.kernel.org/r/20250102163531.63839-2-phasta%40kernel.org
patch subject: [PATCH] ata: Replace deprecated PCI functions
config: powerpc-allmodconfig (https://download.01.org/0day-ci/archive/20250111/202501111455.VMWXk7sN-lkp@intel.com/config)
compiler: powerpc64-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250111/202501111455.VMWXk7sN-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501111455.VMWXk7sN-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/ata/pata_macio.c: In function 'pata_macio_common_init':
>> drivers/ata/pata_macio.c:1089:27: error: assignment to expression with array type
1089 | priv->host->iomap = &priv->tfregs;
| ^
vim +1089 drivers/ata/pata_macio.c
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1048
0ec24914675c48 Greg Kroah-Hartman 2012-12-21 1049 static int pata_macio_common_init(struct pata_macio_priv *priv,
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1050 resource_size_t tfregs,
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1051 resource_size_t dmaregs,
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1052 resource_size_t fcregs,
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1053 unsigned long irq)
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1054 {
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1055 struct ata_port_info pinfo;
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1056 const struct ata_port_info *ppi[] = { &pinfo, NULL };
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1057 void __iomem *dma_regs = NULL;
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1058
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1059 /* Fill up privates with various invariants collected from the
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1060 * device-tree
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1061 */
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1062 pata_macio_invariants(priv);
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1063
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1064 /* Make sure we have sane initial timings in the cache */
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1065 pata_macio_default_timings(priv);
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1066
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1067 /* Allocate libata host for 1 port */
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1068 memset(&pinfo, 0, sizeof(struct ata_port_info));
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1069 pmac_macio_calc_timing_masks(priv, &pinfo);
9cbe056f6c467e Sergei Shtylyov 2011-02-04 1070 pinfo.flags = ATA_FLAG_SLAVE_POSS;
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1071 pinfo.port_ops = &pata_macio_ops;
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1072 pinfo.private_data = priv;
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1073
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1074 priv->host = ata_host_alloc_pinfo(priv->dev, ppi, 1);
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1075 if (priv->host == NULL) {
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1076 dev_err(priv->dev, "Failed to allocate ATA port structure\n");
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1077 return -ENOMEM;
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1078 }
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1079
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1080 /* Setup the private data in host too */
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1081 priv->host->private_data = priv;
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1082
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1083 /* Map base registers */
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1084 priv->tfregs = devm_ioremap(priv->dev, tfregs, 0x100);
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1085 if (priv->tfregs == NULL) {
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1086 dev_err(priv->dev, "Failed to map ATA ports\n");
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1087 return -ENOMEM;
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1088 }
88358ab08944da Benjamin Herrenschmidt 2009-12-01 @1089 priv->host->iomap = &priv->tfregs;
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1090
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1091 /* Map DMA regs */
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1092 if (dmaregs != 0) {
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1093 dma_regs = devm_ioremap(priv->dev, dmaregs,
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1094 sizeof(struct dbdma_regs));
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1095 if (dma_regs == NULL)
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1096 dev_warn(priv->dev, "Failed to map ATA DMA registers\n");
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1097 }
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1098
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1099 /* If chip has local feature control, map those regs too */
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1100 if (fcregs != 0) {
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1101 priv->kauai_fcr = devm_ioremap(priv->dev, fcregs, 4);
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1102 if (priv->kauai_fcr == NULL) {
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1103 dev_err(priv->dev, "Failed to map ATA FCR register\n");
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1104 return -ENOMEM;
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1105 }
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1106 }
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1107
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1108 /* Setup port data structure */
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1109 pata_macio_setup_ios(&priv->host->ports[0]->ioaddr,
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1110 priv->tfregs, dma_regs);
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1111 priv->host->ports[0]->private_data = priv;
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1112
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1113 /* hard-reset the controller */
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1114 pata_macio_reset_hw(priv, 0);
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1115 pata_macio_apply_timings(priv->host->ports[0], 0);
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1116
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1117 /* Enable bus master if necessary */
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1118 if (priv->pdev && dma_regs)
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1119 pci_set_master(priv->pdev);
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1120
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1121 dev_info(priv->dev, "Activating pata-macio chipset %s, Apple bus ID %d\n",
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1122 macio_ata_names[priv->kind], priv->aapl_bus_id);
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1123
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1124 /* Start it up */
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1125 priv->irq = irq;
c3b2889424c26f Tejun Heo 2010-05-19 1126 return ata_host_activate(priv->host, irq, ata_bmdma_interrupt, 0,
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1127 &pata_macio_sht);
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1128 }
88358ab08944da Benjamin Herrenschmidt 2009-12-01 1129
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists