linux-kernel - RE: [PATCH] tty: mips_ejtag_fdc: Fix another passing incompatible pointer type warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <029c01db6409$46e88b50$d4b9a1f0$@aosc.io>
Date: Sat, 11 Jan 2025 17:14:49 +0800
From: <kexybiscuit@...c.io>
To: "'Greg Kroah-Hartman'" <gregkh@...uxfoundation.org>
Cc: "'Jiri Slaby'" <jirislaby@...nel.org>,
	"'Serge Semin'" <fancer.lancer@...il.com>,
	"'Thomas Bogendoerfer'" <tsbogend@...ha.franken.de>,
	<linux-kernel@...r.kernel.org>,
	<linux-serial@...r.kernel.org>
Subject: RE: [PATCH] tty: mips_ejtag_fdc: Fix another passing incompatible pointer type warning

Cool, I'll search the list before sending next time, thanks!

-----Original Message-----
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org> 
Sent: Saturday, January 11, 2025 1:52 PM
To: Kexy Biscuit <kexybiscuit@...c.io>
Cc: Jiri Slaby <jirislaby@...nel.org>; Serge Semin <fancer.lancer@...il.com>; Thomas Bogendoerfer <tsbogend@...ha.franken.de>; linux-kernel@...r.kernel.org; linux-serial@...r.kernel.org
Subject: Re: [PATCH] tty: mips_ejtag_fdc: Fix another passing incompatible pointer type warning

On Sat, Jan 11, 2025 at 01:38:51AM +0800, Kexy Biscuit wrote:
> mips_ejtag_fdc_encode() method was changed to accept u8** since
> ce7cbd9a6c81, but not all occurrences were changed to adapt it.
> 
> Some of the warnings or errors was fixed in a previous commit, this
> commit fixes one more of them.
> 
> drivers/tty/mips_ejtag_fdc.c: In function ‘kgdbfdc_push_one’:
> drivers/tty/mips_ejtag_fdc.c:1224:38: error: passing argument 1 of ‘mips_ejtag_fdc_encode’ from incompatible pointer type [-Werror=incompatible-pointer-types]
>  1224 |         word = mips_ejtag_fdc_encode(bufs, &kgdbfdc_wbuflen, 1);
>       |                                      ^~~~
>       |                                      |
>       |                                      const char **
> drivers/tty/mips_ejtag_fdc.c:216:57: note: expected ‘const u8 **’ {aka ‘const unsigned char **’} but argument is of type ‘const char **’
>   216 | static struct fdc_word mips_ejtag_fdc_encode(const u8 **ptrs,
>       |                                              ~~~~~~~~~~~^~~~
> 
> Fixes: ce7cbd9a6c81 ("tty: mips_ejtag_fdc: use u8 for character pointers")
> Fixes: 188942f05ce4 ("tty: mips_ejtag_fdc: Fix passing incompatible pointer type warning")
> Signed-off-by: Kexy Biscuit <kexybiscuit@...c.io>
> ---
>  drivers/tty/mips_ejtag_fdc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/mips_ejtag_fdc.c b/drivers/tty/mips_ejtag_fdc.c
> index afbf7738c7c47c3377560a3288fa95083dd1c6b0..1cc775e74f92d2c5e7a7b4bb500ff2ae758da8e0 100644
> --- a/drivers/tty/mips_ejtag_fdc.c
> +++ b/drivers/tty/mips_ejtag_fdc.c
> @@ -1215,7 +1215,7 @@ static int kgdbfdc_read_char(void)
>  /* push an FDC word from write buffer to TX FIFO */
>  static void kgdbfdc_push_one(void)
>  {
> -	const char *bufs[1] = { kgdbfdc_wbuf };
> +	const u8 *bufs[1] = { kgdbfdc_wbuf };
>  	struct fdc_word word;
>  	void __iomem *regs;
>  	unsigned int i;

Jiri beat you to it yesterday:
	https://lore.kernel.org/r/20250110115228.603980-1-jirislaby@kernel.org