linux-kernel - Re: [PATCH] Revert "MIPS: csrc-r4k: Select HAVE_UNSTABLE_SCHED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <ea1fc568-91b7-4781-b870-ae90675214e3@app.fastmail.com>
Date: Sat, 11 Jan 2025 10:09:55 +0000
From: "Jiaxun Yang" <jiaxun.yang@...goat.com>
To: "Xi Ruoyao" <xry111@...111.site>,
 "Thomas Bogendoerfer" <tsbogend@...ha.franken.de>
Cc: "linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>,
 linux-kernel@...r.kernel.org,
 "stable@...r.kernel.org" <stable@...r.kernel.org>,
 "Icenowy Zheng" <icenowy@...c.io>
Subject: Re: [PATCH] Revert "MIPS: csrc-r4k: Select HAVE_UNSTABLE_SCHED_CLOCK if SMP &&
 64BIT"



在2024年12月23日十二月 上午9:20，Xi Ruoyao写道：
> This reverts commit 426fa8e4fe7bb914b5977cbce453a9926bf5b2e6.
>
> The commit has caused two issues on Loongson 3A4000:
>
> 1. The timestamp in dmesg become erratic, like:
>
>     [3.736957] amdgpu 0000:04:00.0: ... ...
>     [3.748895] [drm] Initialized amdgpu ... ...
>     [18446744073.381141] amdgpu 0000:04:00:0: ... ...
>     [1.613326] igb 0000:03:00.0 enp3s0: ... ...
>
> 2. More seriously, some workloads (for example, the test
>    stdlib/test-cxa_atexit2 in the Glibc test suite) triggers an RCU
>    stall and hang the system with a high probably (4 hangs out of 5
>    tests).
>
> Revert this commit to use jiffie on Loongson MIPS systems and fix these
> issues for now.  The root cause may need more investigation.
>
> Cc: stable@...r.kernel.org # 6.11+
> Cc: Jiaxun Yang <jiaxun.yang@...goat.com>
> Cc: Icenowy Zheng <icenowy@...c.io>

Reviewed-by: Jiaxun Yang <jiaxun.yang@...goat.com>

It's indeed problematic in some scenarios.

Let's revert for now.

Thanks
- Jiaxun

> Signed-off-by: Xi Ruoyao <xry111@...111.site>
> ---
>  arch/mips/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index 467b10f4361a..5078ebf071ec 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -1084,7 +1084,6 @@ config CSRC_IOASIC
> 
>  config CSRC_R4K
>  	select CLOCKSOURCE_WATCHDOG if CPU_FREQ
> -	select HAVE_UNSTABLE_SCHED_CLOCK if SMP && 64BIT
>  	bool
> 
>  config CSRC_SB1250
> -- 
> 2.47.1

-- 
- Jiaxun