linux-kernel - Re: [PATCH 2/2] dt-bindings: gpio: fairchild,74hc595: use a fallback for Semi MC74HC595A

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2pe3fr5fbt6ifbttknplrkiqhq4gv7qn5pcz7um36hdlcmwud3@jqray4yn75gk>
Date: Sat, 11 Jan 2025 11:50:47 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Bartosz Golaszewski <brgl@...ev.pl>
Cc: Linus Walleij <linus.walleij@...aro.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Maxime Ripard <mripard@...nel.org>, 
	J . Neuschäfer <j.ne@...teo.net>, Csókás Bence <csokas.bence@...lan.hu>, 
	"Geert Uytterhoeven via gmail . com" <geert@...ux-m68k.org>, linux-gpio@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH 2/2] dt-bindings: gpio: fairchild,74hc595: use a fallback
 for Semi MC74HC595A

On Fri, Jan 10, 2025 at 02:00:25PM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> 
> This model is 1:1 compatible with fairchild,74hc595 so use the latter as
> a fallback instead of adding a new stand-alone compatible.
> 
> Fixes: 0ba6cec7acbb ("dt-bindings: gpio: fairchild,74hc595: Add On Semi MC74HC595A compat")
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> ---
>  .../devicetree/bindings/gpio/fairchild,74hc595.yaml    | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml b/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml
> index a209c5b4f6e0..da462dddb140 100644
> --- a/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml
> +++ b/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml
> @@ -28,10 +28,12 @@ maintainers:
>  
>  properties:
>    compatible:
> -    enum:
> -      - fairchild,74hc595
> -      - nxp,74lvc594
> -      - onnn,74hc595a
> +    oneOf:
> +      - const: fairchild,74hc595
> +      - const: nxp,74lvc594

Keep enum for these two, preferred pattern.

> +      - items:
> +          - const: onnn,74hc595a
> +          - const: fairchild,74hc595

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof