linux-kernel - Re: 回覆: [External] Re: [PATCH] net/ncsi: fix locking in Get MAC Address handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGfYmwVECrisZMhWAddmnczcLqFfNZ2boNAD5=p2HHuOhLy75w@mail.gmail.com>
Date: Sat, 11 Jan 2025 19:12:51 +0800
From: Potin Lai <potin.lai.pt@...il.com>
To: Jakub Kicinski <kuba@...nel.org>, Paul Fertser <fercerpav@...il.com>
Cc: Potin Lai (賴柏廷) <Potin.Lai@...ntatw.com>, 
	Samuel Mendoza-Jonas <sam@...dozajonas.com>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Ivan Mikhaylov <fr0st61te@...il.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, 
	"stable@...r.kernel.org" <stable@...r.kernel.org>, 
	Cosmo Chou ( 周楷培) <Cosmo.Chou@...ntatw.com>, 
	"patrick@...cx.xyz" <patrick@...cx.xyz>, Cosmo Chou <chou.cosmo@...il.com>
Subject: Re: 回覆: [External] Re: [PATCH] net/ncsi: fix locking in Get MAC Address handling

On Sat, Jan 11, 2025 at 10:18 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Fri, 10 Jan 2025 06:02:04 +0000 Potin Lai (賴柏廷) wrote:
> > > Neat!
> > > Potin, please give this a test ASAP.
> >
> > Thanks for the new patch.
> > I am currently tied up with other tasks, but I’ll make sure to test
> > it as soon as possible and share the results with you.
>
> Understood, would you be able to test it by January 13th?
> Depending on how long we need to wait we may be better off
> applying the patch already or waiting with committing..

Hi Jakub & Paul,

I had a test yesterday, the patch is working and the kernel panic does
not happen any more, but we notice sometimes the config_apply_mac
state runs before the gma command is handled.

Cosmo helped me to find a potential state handling issue, and I
submitted the v2 version.
Please kindly have a look at v2 version with the link below.
v2: https://lore.kernel.org/all/20250111-fix-ncsi-mac-v2-0-838e0a1a233a@gmail.com/

Best Regards,
Potin