linux-kernel - Re: [PATCH V3 4/8] remoteproc: qcom: add hexagon based WCSS secure PIL driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8468e80f-ecf9-4c35-8078-6afa0fe25594@quicinc.com>
Date: Sat, 11 Jan 2025 19:16:20 +0530
From: Kathiravan Thirumoorthy <quic_kathirav@...cinc.com>
To: Gokul Sriram Palanisamy <quic_gokulsri@...cinc.com>,
        Bjorn Andersson
	<andersson@...nel.org>
CC: "jassisinghbrar@...il.com" <jassisinghbrar@...il.com>,
        "robh@...nel.org"
	<robh@...nel.org>,
        "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
        "conor+dt@...nel.org" <conor+dt@...nel.org>,
        "mathieu.poirier@...aro.org"
	<mathieu.poirier@...aro.org>,
        "konradybcio@...nel.org"
	<konradybcio@...nel.org>,
        "Manikanta Mylavarapu (QUIC)"
	<quic_mmanikan@...cinc.com>,
        "linux-arm-msm@...r.kernel.org"
	<linux-arm-msm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>,
        "linux-remoteproc@...r.kernel.org"
	<linux-remoteproc@...r.kernel.org>,
        "dmitry.baryshkov@...aro.org"
	<dmitry.baryshkov@...aro.org>,
        "Vignesh Viswanathan (QUIC)"
	<quic_viswanat@...cinc.com>,
        "Sricharan Ramabadhran (QUIC)"
	<quic_srichara@...cinc.com>
Subject: Re: [PATCH V3 4/8] remoteproc: qcom: add hexagon based WCSS secure
 PIL driver



>>> +static int wcss_sec_start(struct rproc *rproc)
>>> +{
>>> +	struct wcss_sec *wcss = rproc->priv;
>>> +	struct device *dev = wcss->dev;
>>> +	const struct wcss_data *desc = of_device_get_match_data(dev);
>>
>> Please avoid "parsing" DT in runtime.
> 
> I didn't underatand this.
> 

IIUC, you should handle this in probe (one time) rather than for every 
wcss_sec_start() call. In probe, you are already fetching this data. So 
you can re-use the wcss->desc instead of parsing it again.