linux-kernel - Re: [PATCH v6 00/16] perf tools: Use generic syscall scripts for all archs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <721EF5C4-5B22-4654-8328-F3616CDD1D29@linux.vnet.ibm.com>
Date: Sat, 11 Jan 2025 19:33:46 +0530
From: Athira Rajeev <atrajeev@...ux.vnet.ibm.com>
To: Arnaldo Carvalho de Melo <acme@...nel.org>,
        Charlie Jenkins <charlie@...osinc.com>
Cc: Charlie Jenkins <charlie@...osinc.com>, Namhyung Kim <namhyung@...nel.org>,
        Ian Rogers <irogers@...gle.com>, Hari Bathini <hbathini@...ux.ibm.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>, Adrian Hunter <adrian.hunter@...el.com>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Mickaël Salaün <mic@...ikod.net>,
        Günther Noack <gnoack@...gle.com>,
        Christian Brauner <brauner@...nel.org>, Guo Ren <guoren@...nel.org>,
        John Garry <john.g.garry@...cle.com>, Will Deacon <will@...nel.org>,
        James Clark <james.clark@...aro.org>,
        Mike Leach <mike.leach@...aro.org>, Leo Yan <leo.yan@...ux.dev>,
        Jonathan Corbet <corbet@....net>, Arnd Bergmann <arnd@...db.de>,
        linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
        linux-riscv@...ts.infradead.org, linux-security-module@...r.kernel.org,
        bpf@...r.kernel.org, linux-csky@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH v6 00/16] perf tools: Use generic syscall scripts for all
 archs



> On 10 Jan 2025, at 8:13 PM, Arnaldo Carvalho de Melo <acme@...nel.org> wrote:
> 
> On Fri, Jan 10, 2025 at 12:34:46PM +0530, Athira Rajeev wrote:
>> 
>> 
>>> On 10 Jan 2025, at 2:44 AM, Charlie Jenkins <charlie@...osinc.com> wrote:
>>> 
>>> On Thu, Jan 09, 2025 at 05:49:39PM -0300, Arnaldo Carvalho de Melo wrote:
>>>> On Thu, Jan 09, 2025 at 11:48:36AM -0800, Charlie Jenkins wrote:
>>>>> On Thu, Jan 09, 2025 at 12:59:43PM -0300, Arnaldo Carvalho de Melo wrote:
>>>>>> ⬢ [acme@...lbox perf-tools-next]$ git log --oneline -1 ; time make -C tools/perf build-test
>>>>>> d06826160a982494 (HEAD -> perf-tools-next) perf tools: Remove dependency on libaudit
>>>>>> make: Entering directory '/home/acme/git/perf-tools-next/tools/perf'
>>>>>> - tarpkg: ./tests/perf-targz-src-pkg .
>>>>>>                make_static: cd . && make LDFLAGS=-static NO_PERF_READ_VDSO32=1 NO_PERF_READ_VDSOX32=1 NO_JVMTI=1 NO_LIBTRACEEVENT=1 NO_LIBELF=1 -j28  DESTDIR=/tmp/tmp.JJT3tvN7bV
>>>>>>             make_with_gtk2: cd . && make GTK2=1 -j28  DESTDIR=/tmp/tmp.BF53V2qpl3
>>>>>> - /home/acme/git/perf-tools-next/tools/perf/BUILD_TEST_FEATURE_DUMP: cd . && make FEATURE_DUMP_COPY=/home/acme/git/perf-tools-next/tools/perf/BUILD_TEST_FEATURE_DUMP  feature-dump
>>>>>> cd . && make FEATURE_DUMP_COPY=/home/acme/git/perf-tools-next/tools/perf/BUILD_TEST_FEATURE_DUMP feature-dump
>>>>>>        make_no_libbionic_O: cd . && make NO_LIBBIONIC=1 FEATURES_DUMP=/home/acme/git/perf-tools-next/tools/perf/BUILD_TEST_FEATURE_DUMP -j28 O=/tmp/tmp.KZuQ0q2Vs6 DESTDIR=/tmp/tmp.0sxMyH91gS
>>>>>>          make_util_map_o_O: cd . && make util/map.o FEATURES_DUMP=/home/acme/git/perf-tools-next/tools/perf/BUILD_TEST_FEATURE_DUMP -j28 O=/tmp/tmp.Y0Mx3KLREI DESTDIR=/tmp/tmp.wg9HCVVLHE
>>>>>>             make_install_O: cd . && make install FEATURES_DUMP=/home/acme/git/perf-tools-next/tools/perf/BUILD_TEST_FEATURE_DUMP -j28 O=/tmp/tmp.P0LEBAkW1X DESTDIR=/tmp/tmp.agTavZndFN
>>>>>> failed to find: etc/bash_completion.d/perf
>>>>> 
>>>>> Is this something introduced by this patch?
>>>> 
>>>> I don't think so.
>>>> 
>>>> BTW this series is already pushed out to perf-tools-next:
>>>> 
>>>> https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/log/?h=perf-tools-next
>>>> 
>>>> Thanks!
>>>> 
>>>> - Arnaldo
>>> 
>>> Thank you!
>>> 
>>> - Charlie
>> 
>> Hi Charlie, Arnaldo
>> 
>> While testing the series, I hit compilation issue in powerpc
>> 
>> Snippet of logs:
> 
> Yeah, Stephen Rothwell noticed it in linux next and Charlie provided a
> fix, so I squashed it all together and will push it soon:
> 
>    Link: https://lore.kernel.org/r/20250108-perf_syscalltbl-v6-14-7543b5293098@rivosinc.com
>    Link: https://lore.kernel.org/lkml/20250110100505.78d81450@canb.auug.org.au
>    [ Stephen Rothwell noticed on linux-next that the powerpc build for perf was broken and ...]
>    Link: https://lore.kernel.org/lkml/20250109-perf_powerpc_spu-v1-1-c097fc43737e@rivosinc.com
>    [ ... Charlie fixed it up and asked for it to be squashed to avoid breaking bisection. o
> 
> Thanks for the report!
> 
Sure,
Thanks Charlie for the fix

I tested on latest tmp.perf-tools-next and compiles fine

Tested-by: Athira Rajeev <atrajeev@...ux.vnet.ibm.com>

Thanks
Athira


> - Arnaldo