linux-kernel - Re: [PATCH] hwmon: Fix help text for aspeed-g6-pwm-tach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7642492f-85d2-48d4-b988-d1ce9010c1d1@roeck-us.net>
Date: Sat, 11 Jan 2025 07:52:33 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Joel Stanley <joel@....id.au>
Cc: Jean Delvare <jdelvare@...e.com>,
	Billy Tsai <billy_tsai@...eedtech.com>, linux-hwmon@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-aspeed@...ts.ozlabs.org
Subject: Re: [PATCH] hwmon: Fix help text for aspeed-g6-pwm-tach

On Fri, Jan 10, 2025 at 10:17:36PM +1030, Joel Stanley wrote:
> The help text has the wrong module name mentioned, and the capitalisation
> of the title is inconsistent.
> 
> Fixes: 7e1449cd15d1 ("hwmon: (aspeed-g6-pwm-tacho): Support for ASPEED g6 PWM/Fan tach")
> Signed-off-by: Joel Stanley <joel@....id.au>

Applied.

Guenter

> ---
> The naming for this driver unusual; other aspeed devices are named for
> the soc name (ast2400, ast2500, etc) that introduced them, not the
> generation.
> 
> Additionally this driver uses the abbreviation "tach", while the other
> uses "tacho".
> 
>  drivers/hwmon/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> index dd376602f3f1..9afa70f877cc 100644
> --- a/drivers/hwmon/Kconfig
> +++ b/drivers/hwmon/Kconfig
> @@ -413,7 +413,7 @@ config SENSORS_ASPEED
>  	  will be called aspeed_pwm_tacho.
>  
>  config SENSORS_ASPEED_G6
> -	tristate "ASPEED g6 PWM and Fan tach driver"
> +	tristate "ASPEED G6 PWM and Fan tach driver"
>  	depends on ARCH_ASPEED || COMPILE_TEST
>  	depends on PWM
>  	help
> @@ -421,7 +421,7 @@ config SENSORS_ASPEED_G6
>  	  controllers.
>  
>  	  This driver can also be built as a module. If so, the module
> -	  will be called aspeed_pwm_tacho.
> +	  will be called aspeed_g6_pwm_tach.
>  
>  config SENSORS_ATXP1
>  	tristate "Attansic ATXP1 VID controller"