linux-kernel - Re: [External Mail] [PATCH v2 0/5] Move kvfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0c6fea47-c0ac-4398-a820-ac33f981c1f9@suse.cz>
Date: Sat, 11 Jan 2025 20:43:53 +0100
From: Vlastimil Babka <vbabka@...e.cz>
To: Hyeonggon Yoo <hyeonggon.yoo@...com>,
 "Uladzislau Rezki (Sony)" <urezki@...il.com>,
 "linux-mm@...ck.org" <linux-mm@...ck.org>,
 "Paul E . McKenney" <paulmck@...nel.org>,
 Andrew Morton <akpm@...ux-foundation.org>
Cc: kernel_team@...ynix.com, 42.hyeyoo@...il.com, RCU <rcu@...r.kernel.org>,
 LKML <linux-kernel@...r.kernel.org>, Christoph Lameter <cl@...ux.com>,
 Pekka Enberg <penberg@...nel.org>, David Rientjes <rientjes@...gle.com>,
 Joonsoo Kim <iamjoonsoo.kim@....com>,
 Roman Gushchin <roman.gushchin@...ux.dev>,
 Oleksiy Avramchenko <oleksiy.avramchenko@...y.com>
Subject: Re: [External Mail] [PATCH v2 0/5] Move kvfree_rcu() into SLAB (v2)

On 1/6/25 08:21, Hyeonggon Yoo wrote:
> 
> 
> On 2024-12-13 3:02 AM, Uladzislau Rezki (Sony) wrote:
>> Hello!
>> 
>> This is v2. It is based on the Linux 6.13-rc2. The first version is
>> here:
>> 
>> https://lore.kernel.org/linux-mm/20241210164035.3391747-4-urezki@gmail.com/T/
>> 
>> The difference between v1 and v2 is that, the preparation process is
>> done in original place instead and after that there is one final move.
>> 
>> Uladzislau Rezki (Sony) (5):
>>    rcu/kvfree: Initialize kvfree_rcu() separately
>>    rcu/kvfree: Move some functions under CONFIG_TINY_RCU
>>    rcu/kvfree: Adjust names passed into trace functions
>>    rcu/kvfree: Adjust a shrinker name
>>    mm/slab: Move kvfree_rcu() into SLAB
>> 
>>   include/linux/slab.h |   1 +
>>   init/main.c          |   1 +
>>   kernel/rcu/tree.c    | 876 ------------------------------------------
>>   mm/slab_common.c     | 880 +++++++++++++++++++++++++++++++++++++++++++
>>   4 files changed, 882 insertions(+), 876 deletions(-)
> 
> Sorry for the late reply, but better late than never...
> 
> FWIW,
> 
> Acked-by: Hyeonggon Yoo <hyeonggon.yoo@...com>
> Tested-by: Hyeonggon Yoo <hyeonggon.yoo@...com>

Thanks, applied.

> Thanks for all the efforts!
> 
> By the way, any future plans how to take advantage of internal slab
> state?

One way is the sheaves effort which in the last RFC also replaced the way
kfree_rcu() is handled for caches with enabled sheaves.

Perhaps even without those we could consider e.g. doing the kfree_rcu()
batching by grouping the pending frees per kmem cache, which could perhaps
lead to more efficient flushing later.

> --
> Hyeonggon