[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <34f7e4c0-5385-442f-a4a1-7813b40c40dc@roeck-us.net>
Date: Sat, 11 Jan 2025 14:45:03 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Peter Korsgaard <peter@...sgaard.com>
Cc: Rob Herring <robh@...nel.org>, devicetree@...r.kernel.org,
linux-hwmon@...r.kernel.org, Jean Delvare <jdelvare@...e.com>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 1/2] dt-bindings: hwmon: pwm-fan: Document default-pwm
property
On 1/11/25 10:24, Peter Korsgaard wrote:
>>>>>> "Guenter" == Guenter Roeck <linux@...ck-us.net> writes:
>
> Hi,
>
> >> Guenter, what do you say? This way we don't need any new device tree
> >> properties. I personally find it less clear than a default-pwm property,
> >> but oh well.
> >>
>
> > I would not call that "default". It is more along the line of
> > "If available, use highest cooling level as maximum allowed".
>
> Sorry, what are you referring to exactly? The commit message? The change
> is about the default/initial pwm setting, there is nothing disallowing
> user space to increase it afterwards?
>
From the current probe function:
"Set duty cycle to maximum allowed". If you dislike the term "maximum allowed",
please consider something like "Set initial duty cycle to maximum or, if provided,
to the highest cooling level".
Guenter
Powered by blists - more mailing lists