linux-kernel - Re: [PATCH v2] net: stmmac: sti: Switch from CONFIG_PM_SLEEP guards to pm_sleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ac947d88-750e-4058-aa3e-b539a09b89d0@linux.dev>
Date: Sun, 12 Jan 2025 20:35:32 +0800
From: Yanteng Si <si.yanteng@...ux.dev>
To: Raphael Gallais-Pou <rgallaispou@...il.com>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>,
 Jose Abreu <joabreu@...opsys.com>, Andrew Lunn <andrew+netdev@...n.ch>,
 "'David S . Miller'" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Maxime Coquelin <mcoquelin.stm32@...il.com>
Cc: netdev@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] net: stmmac: sti: Switch from CONFIG_PM_SLEEP guards
 to pm_sleep_ptr()


在 1/9/25 23:58, Raphael Gallais-Pou 写道:
> Letting the compiler remove these functions when the kernel is built
> without CONFIG_PM_SLEEP support is simpler and less error prone than the
> use of #ifdef based kernel configuration guards.
>
> Signed-off-by: Raphael Gallais-Pou <rgallaispou@...il.com>

LGTM!


Reviewed-by: Yanteng Si <si.yanteng@...ux.dev>


Thanks,

Yanteng

> ---
> Changes in v2:
>    - Split serie in single patches
>    - Remove irrelevant 'Link:' from commit log
>    - Link to v1: https://lore.kernel.org/r/20241229-update_pm_macro-v1-5-c7d4c4856336@gmail.com
> ---
>   drivers/net/ethernet/stmicro/stmmac/dwmac-sti.c | 8 +++-----
>   1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sti.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sti.c
> index eabc4da9e1a9..de9b6dfef15b 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sti.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sti.c
> @@ -313,7 +313,6 @@ static void sti_dwmac_remove(struct platform_device *pdev)
>   	clk_disable_unprepare(dwmac->clk);
>   }
>   
> -#ifdef CONFIG_PM_SLEEP
>   static int sti_dwmac_suspend(struct device *dev)
>   {
>   	struct sti_dwmac *dwmac = get_stmmac_bsp_priv(dev);
> @@ -333,10 +332,9 @@ static int sti_dwmac_resume(struct device *dev)
>   
>   	return stmmac_resume(dev);
>   }
> -#endif /* CONFIG_PM_SLEEP */
>   
> -static SIMPLE_DEV_PM_OPS(sti_dwmac_pm_ops, sti_dwmac_suspend,
> -					   sti_dwmac_resume);
> +static DEFINE_SIMPLE_DEV_PM_OPS(sti_dwmac_pm_ops, sti_dwmac_suspend,
> +						  sti_dwmac_resume);
>   
>   static const struct sti_dwmac_of_data stih4xx_dwmac_data = {
>   	.fix_retime_src = stih4xx_fix_retime_src,
> @@ -353,7 +351,7 @@ static struct platform_driver sti_dwmac_driver = {
>   	.remove = sti_dwmac_remove,
>   	.driver = {
>   		.name           = "sti-dwmac",
> -		.pm		= &sti_dwmac_pm_ops,
> +		.pm		= pm_sleep_ptr(&sti_dwmac_pm_ops),
>   		.of_match_table = sti_dwmac_match,
>   	},
>   };