linux-kernel - Re: [PATCH] pm: Replace deprecated kmap_atomic() with kmap_local

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202501122002.vD4o8M9T-lkp@intel.com>
Date: Sun, 12 Jan 2025 20:43:24 +0800
From: kernel test robot <lkp@...el.com>
To: David Reaver <me@...idreaver.com>,
	"Rafael J . Wysocki" <rafael@...nel.org>,
	Pavel Machek <pavel@....cz>, Len Brown <len.brown@...el.com>
Cc: oe-kbuild-all@...ts.linux.dev, David Reaver <me@...idreaver.com>,
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
	Ira Weiny <ira.weiny@...el.com>
Subject: Re: [PATCH] pm: Replace deprecated kmap_atomic() with
 kmap_local_page()

Hi David,

kernel test robot noticed the following build warnings:

[auto build test WARNING on amd-pstate/linux-next]
[also build test WARNING on amd-pstate/bleeding-edge linus/master v6.13-rc6 next-20250110]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/David-Reaver/pm-Replace-deprecated-kmap_atomic-with-kmap_local_page/20250112-100253
base:   https://git.kernel.org/pub/scm/linux/kernel/git/superm1/linux.git linux-next
patch link:    https://lore.kernel.org/r/20250112015535.191527-1-me%40davidreaver.com
patch subject: [PATCH] pm: Replace deprecated kmap_atomic() with kmap_local_page()
config: i386-buildonly-randconfig-005-20250112 (https://download.01.org/0day-ci/archive/20250112/202501122002.vD4o8M9T-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250112/202501122002.vD4o8M9T-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501122002.vD4o8M9T-lkp@intel.com/

All warnings (new ones prefixed by >>):

   kernel/power/snapshot.c: In function 'copy_last_highmem_page':
   kernel/power/snapshot.c:2567:23: error: implicit declaration of function 'kmap_page_local' [-Werror=implicit-function-declaration]
    2567 |                 dst = kmap_page_local(last_highmem_page);
         |                       ^~~~~~~~~~~~~~~
>> kernel/power/snapshot.c:2567:21: warning: assignment to 'void *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
    2567 |                 dst = kmap_page_local(last_highmem_page);
         |                     ^
   cc1: some warnings being treated as errors


vim +2567 kernel/power/snapshot.c

  2554	
  2555	/**
  2556	 * copy_last_highmem_page - Copy most the most recent highmem image page.
  2557	 *
  2558	 * Copy the contents of a highmem image from @buffer, where the caller of
  2559	 * snapshot_write_next() has stored them, to the right location represented by
  2560	 * @last_highmem_page .
  2561	 */
  2562	static void copy_last_highmem_page(void)
  2563	{
  2564		if (last_highmem_page) {
  2565			void *dst;
  2566	
> 2567			dst = kmap_page_local(last_highmem_page);
  2568			copy_page(dst, buffer);
  2569			kunmap_local(dst);
  2570			last_highmem_page = NULL;
  2571		}
  2572	}
  2573	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki