linux-kernel - Re: [PATCH v2 1/9] iio: dac: ad3552r-common: fix ad3541/2r ranges

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250112133526.4f7bdb00@jic23-huawei>
Date: Sun, 12 Jan 2025 13:35:26 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: David Lechner <dlechner@...libre.com>
Cc: Angelo Dureghello <adureghello@...libre.com>, Lars-Peter Clausen
 <lars@...afoo.de>, Michael Hennerich <Michael.Hennerich@...log.com>, Mihail
 Chindris <mihail.chindris@...log.com>, Nuno Sa <nuno.sa@...log.com>,
 Jonathan Cameron <Jonathan.Cameron@...wei.com>, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/9] iio: dac: ad3552r-common: fix ad3541/2r ranges

On Wed, 8 Jan 2025 14:43:22 -0600
David Lechner <dlechner@...libre.com> wrote:

> On 1/8/25 11:29 AM, Angelo Dureghello wrote:
> > From: Angelo Dureghello <adureghello@...libre.com>
> > 
> > Fix ad3541/2r voltage ranges to be as per ad3542r datasheet,
> > rev. C, table 38 (page 57).
> > 
> > The wrong ad354xr ranges was generating erroneous Vpp output.
> > 
> > In more details:
> > - fix wrong number of ranges, they are 5 ranges, not 6,
> > - remove non-existent 0-3V range,
> > - adjust order, since ad3552r_find_range() get a wrong index,
> >   producing a wrong Vpp as output.
> > 
> > Retested all the ranges on real hardware, EVALAD3542RFMCZ:
> > 
> > adi,output-range-microvolt (fdt):
> > <(000000) (2500000)>;   ok (Rfbx1, switch 10)
> > <(000000) (5000000)>;   ok (Rfbx1, switch 10)
> > <(000000) (10000000)>;  ok (Rfbx1, switch 10)
> > <(-5000000) (5000000)>; ok (Rfbx2, switch +/- 5)
> > <(-2500000) (7500000)>; ok (Rfbx2, switch -2.5/7.5)
> > 
> > Fixes: 8f2b54824b28 ("drivers:iio:dac: Add AD3552R driver support")
> > Signed-off-by: Angelo Dureghello <adureghello@...libre.com>
> > ---  
> Reviewed-by: David Lechner <dlechner@...libre.com>
> 

Applied to the fixes-togreg branch of iio.git and marked for stable.

Thanks,

Jonathan