linux-kernel - Re: [PATCH v4 5/6] iio: imu: adis16550: add adis16550 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250112153358.16631b46@jic23-huawei>
Date: Sun, 12 Jan 2025 15:33:58 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: kernel test robot <lkp@...el.com>
Cc: Robert Budai <robert.budai@...log.com>, Nuno Sa <nuno.sa@...log.com>,
 Ramona Gradinariu <ramona.gradinariu@...log.com>, Antoniu Miclaus
 <antoniu.miclaus@...log.com>, Lars-Peter Clausen <lars@...afoo.de>, Michael
 Hennerich <Michael.Hennerich@...log.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 Jonathan Corbet <corbet@....net>, Alex Lanzano <lanzano.alex@...il.com>,
 linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
 oe-kbuild-all@...ts.linux.dev
Subject: Re: [PATCH v4 5/6] iio: imu: adis16550: add adis16550 support

On Sat, 11 Jan 2025 20:03:22 +0800
kernel test robot <lkp@...el.com> wrote:

> Hi Robert,
> 
> kernel test robot noticed the following build errors:
> 
> [auto build test ERROR on jic23-iio/togreg]
> [also build test ERROR on linus/master v6.13-rc6 next-20250110]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Robert-Budai/iio-imu-adis-Add-custom-ops-struct/20250110-154645
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
> patch link:    https://lore.kernel.org/r/20250110074254.38966-6-robert.budai%40analog.com
> patch subject: [PATCH v4 5/6] iio: imu: adis16550: add adis16550 support
> config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20250111/202501111951.NHXp98OK-lkp@intel.com/config)
> compiler: m68k-linux-gcc (GCC) 14.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250111/202501111951.NHXp98OK-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202501111951.NHXp98OK-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
>    In file included from include/linux/module.h:22,
>                     from include/linux/device/driver.h:21,
>                     from include/linux/device.h:32,
>                     from include/linux/iio/iio.h:10,
>                     from include/linux/iio/buffer.h:10,
>                     from drivers/iio/imu/adis16550.c:12:
> >> drivers/iio/imu/adis16550.c:1202:18: error: expected ',' or ';' before 'IIO_ADISLIB'  
>     1202 | MODULE_IMPORT_NS(IIO_ADISLIB);
>          |                  ^~~~~~~~~~~
>    include/linux/moduleparam.h:26:61: note: in definition of macro '__MODULE_INFO'
>       26 |                 = __MODULE_INFO_PREFIX __stringify(tag) "=" info
>          |                                                             ^~~~
>    include/linux/module.h:299:33: note: in expansion of macro 'MODULE_INFO'
>      299 | #define MODULE_IMPORT_NS(ns)    MODULE_INFO(import_ns, ns)
>          |                                 ^~~~~~~~~~~
>    drivers/iio/imu/adis16550.c:1202:1: note: in expansion of macro 'MODULE_IMPORT_NS'
>     1202 | MODULE_IMPORT_NS(IIO_ADISLIB);
>          | ^~~~~~~~~~~~~~~~
> 
> 
> vim +1202 drivers/iio/imu/adis16550.c
> 
>   1196	
>   1197	MODULE_AUTHOR("Nuno Sa <nuno.sa@...log.com>");
>   1198	MODULE_AUTHOR("Ramona Gradinariu <ramona.gradinariu@...log.com>");
>   1199	MODULE_AUTHOR("Antoniu Miclaus <antoniu.miclaus@...log.com>");
>   1200	MODULE_DESCRIPTION("Analog Devices ADIS16550 IMU driver");
>   1201	MODULE_LICENSE("GPL");
> > 1202	MODULE_IMPORT_NS(IIO_ADISLIB);  
> 

You need a base commit from rc2 or above.  (technically 2 patches after rc1
but rc2 is probably a better choice!)  This will be material for next kernel
release anyway now so this all may become moot!

Jonathan