linux-kernel - Re: [PATCH 3/3] docs: submitting-patches: clarify that signers may use their discretion on tags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEg-Je-Knta8BtYSbZgX8cZ9Gd-2cpDAUE83dCJZbTbqmSfcKA@mail.gmail.com>
Date: Sun, 12 Jan 2025 10:47:02 -0500
From: Neal Gompa <neal@...pa.dev>
To: Miguel Ojeda <ojeda@...nel.org>
Cc: Jonathan Corbet <corbet@....net>, workflows@...r.kernel.org, linux-doc@...r.kernel.org, 
	linux-kernel@...r.kernel.org, patches@...ts.linux.dev, 
	Sami Tolvanen <samitolvanen@...gle.com>, Masahiro Yamada <masahiroy@...nel.org>, 
	Luis Chamberlain <mcgrof@...nel.org>, tech-board@...ups.linuxfoundation.org, 
	Steven Rostedt <rostedt@...dmis.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Linus Torvalds <torvalds@...ux-foundation.org>, Dan Williams <dan.j.williams@...el.com>, 
	Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH 3/3] docs: submitting-patches: clarify that signers may
 use their discretion on tags

On Sun, Jan 12, 2025 at 10:30 AM Miguel Ojeda <ojeda@...nel.org> wrote:
>
> Tags are really appreciated by maintainers in general, since it means
> someone is willing to put their name on a commit, be it as a reviewer,
> tester, etc.
>
> However, signers (i.e. submitters carrying tags from previous versions
> and maintainers applying patches) may need to take or drop tags, on a
> case-by-case basis, for different reasons.
>
> Yet this is not explicitly spelled out in the documentation, thus there
> may be instances [1] where contributors may feel unwelcome.
>
> Thus, to clarify, state this clearly.
>
> Link: https://lore.kernel.org/rust-for-linux/CAEg-Je-h4NitWb2ErFGCOqt0KQfXuyKWLhpnNHCdRzZdxi018Q@mail.gmail.com/ [1]
> Suggested-by: Dan Williams <dan.j.williams@...el.com>
> Acked-by: Shuah Khan <skhan@...uxfoundation.org>
> Acked-by: Dan Williams <dan.j.williams@...el.com>
> Signed-off-by: Miguel Ojeda <ojeda@...nel.org>
> ---
>  Documentation/process/submitting-patches.rst | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst
> index 7b0ac7370cb1..6754bc15f989 100644
> --- a/Documentation/process/submitting-patches.rst
> +++ b/Documentation/process/submitting-patches.rst
> @@ -614,6 +614,10 @@ process nor the requirement to Cc: stable@...r.kernel.org on all stable
>  patch candidates. For more information, please read
>  Documentation/process/stable-kernel-rules.rst.
>
> +Finally, while providing tags is welcome and typically very appreciated, please
> +note that signers (i.e. submitters and maintainers) may use their discretion in
> +applying offered tags.
> +
>  .. _the_canonical_patch_format:
>
>  The canonical patch format
> --
> 2.48.0
>

A tag must not be dropped without the tag submitter's authorization.
Otherwise it doesn't matter what you write here, the submitter *will*
feel unwelcome.

It is rude and discouraging to do so without their acceptance of doing so.


-- 
真実はいつも一つ！/ Always, there's only one truth!