linux-kernel - Re: [PATCH v9 2/4] iio: accel: adxl345: initialize FIFO delay value for SPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z4PlrkU6Ml9N4tx1@surfacebook.localdomain>
Date: Sun, 12 Jan 2025 17:54:22 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Lothar Rubusch <l.rubusch@...il.com>
Cc: lars@...afoo.de, Michael.Hennerich@...log.com, jic23@...nel.org,
	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
	eraretuya@...il.com
Subject: Re: [PATCH v9 2/4] iio: accel: adxl345: initialize FIFO delay value
 for SPI

Sat, Dec 28, 2024 at 11:29:47PM +0000, Lothar Rubusch kirjoitti:
> Add the possibility to delay FIFO access when SPI is used. According to
> the datasheet this is needed for the adxl345. When initialization
> happens over SPI the need for delay is to be signalized, and the delay
> will be used.

...

>  int adxl345_core_probe(struct device *dev, struct regmap *regmap,
> +		       bool fifo_delay_default,
>  		       int (*setup)(struct device*, struct regmap*));

Missing spaces, but it seems the original issue.

...

>  int adxl345_core_probe(struct device *dev, struct regmap *regmap,
> +		       bool fifo_delay_default,
>  		       int (*setup)(struct device*, struct regmap*))

Ditto.

...

>  #define ADXL345_MAX_SPI_FREQ_HZ		5000000
> +#define ADXL345_MAX_FREQ_NO_FIFO_DELAY	1500000

In which units? Usually we add a unit suffix, e.g., _US (for microseconds).

-- 
With Best Regards,
Andy Shevchenko