linux-kernel - Re: [PATCH 2/3] docs: submitting-patches: clarify difference between Acked-by and Reviewed-by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878qrfdcro.fsf@trenco.lwn.net>
Date: Sun, 12 Jan 2025 12:59:23 -0700
From: Jonathan Corbet <corbet@....net>
To: Neal Gompa <neal@...pa.dev>, Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc: Miguel Ojeda <ojeda@...nel.org>, workflows@...r.kernel.org,
 linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
 patches@...ts.linux.dev, Sami Tolvanen <samitolvanen@...gle.com>, Masahiro
 Yamada <masahiroy@...nel.org>, Luis Chamberlain <mcgrof@...nel.org>,
 tech-board@...ups.linuxfoundation.org, Steven Rostedt
 <rostedt@...dmis.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Linus Torvalds <torvalds@...ux-foundation.org>, Shuah Khan
 <skhan@...uxfoundation.org>, Dan Williams <dan.j.williams@...el.com>,
 "Darrick J. Wong" <djwong@...nel.org>
Subject: Re: [PATCH 2/3] docs: submitting-patches: clarify difference
 between Acked-by and Reviewed-by

Neal Gompa <neal@...pa.dev> writes:

> I've had my Reviewed-by tags silently ignored or deliberately stripped
> because even though I've done a technical review, the maintainer does
> not believe that I did. Therefore, what I am saying is that
> maintainers seem to speciously decide whether an Acked-by or
> Reviewed-by tag is appropriate or not *after* someone has sent it.
>
> This is the fundamental problem I have right now. This decision is not
> the maintainer's to make, it is the submitter's.

There *are* people who seem to make a game of getting as many such tags
into the repository as possible.  I think a bit of maintainer discretion
is important here; I don't believe that there is a fundamental right to
inject a tag into somebody else's patch...?

jon