linux-kernel - Re: [PATCH] wifi: mac80211: fix interger overflow in hwmp_route_info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a6bd38c58f2f7685eac53844f2336432503c328e.camel@sipsolutions.net>
Date: Mon, 13 Jan 2025 16:05:27 +0100
From: Johannes Berg <johannes@...solutions.net>
To: Gavrilov Ilia <Ilia.Gavrilov@...otecs.ru>
Cc: Julan Hsu <julanhsu@...gle.com>, "linux-wireless@...r.kernel.org"
	 <linux-wireless@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	 <linux-kernel@...r.kernel.org>, "lvc-project@...uxtesting.org"
	 <lvc-project@...uxtesting.org>, "stable@...r.kernel.org"
	 <stable@...r.kernel.org>
Subject: Re: [PATCH] wifi: mac80211: fix interger overflow in
 hwmp_route_info_get()

On Thu, 2024-12-26 at 07:47 +0000, Gavrilov Ilia wrote:
> Since the new_metric and last_hop_metric variables can reach
> the MAX_METRIC(0xffffffff) value, an integer overflow may occur
> when multiplying them by 10/9. It can lead to incorrect behavior.
> 
> Found by InfoTeCS on behalf of Linux Verification Center
> (linuxtesting.org) with SVACE.
> 
> -					      mult_frac(new_metric, 10, 9) :
> +					      mult_frac((u64)new_metric, 10, 9) :
> 

As you would expect, this doesn't build on 32-bit.

johannnes