linux-kernel - Re: [PATCH v2] ARM: dts: aspeed: catalina: Update DTS to support multiple PDB board sources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <173678161661.2153651.3945745286602645687.robh@kernel.org>
Date: Mon, 13 Jan 2025 09:26:10 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Potin Lai <potin.lai.pt@...il.com>
Cc: linux-aspeed@...ts.ozlabs.org, Joel Stanley <joel@....id.au>, 
 devicetree@...r.kernel.org, Andrew Jeffery <andrew@...econstruct.com.au>, 
 linux-arm-kernel@...ts.infradead.org, Patrick Williams <patrick@...cx.xyz>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, linux-kernel@...r.kernel.org, 
 Cosmo Chou <cosmo.chou@...ntatw.com>, Potin Lai <potin.lai@...ntatw.com>, 
 Conor Dooley <conor+dt@...nel.org>
Subject: Re: [PATCH v2] ARM: dts: aspeed: catalina: Update DTS to support
 multiple PDB board sources


On Mon, 13 Jan 2025 14:16:23 +0800, Potin Lai wrote:
> This patch updates the Catalina device tree to support different sources
> of PDB boards.
> 
> Changes for Main source PDB board
> - Thermal Sensor Monitoring:
>   - Added IOB NIC nodes (TMP421) for thermal sensor monitoring.
>   - Added FIO remote thermal node (TMP75) for thermal sensor monitoring.
> - Fan Monitoring and Control:
>   - Add fan p12V power sensor node (MP5990) for sensor monitoring.
>   - Add fan controllers (MAX31790) for fan control and tach monitoring.
> 
> Changes for 2nd source PDB board
> - Fan Monitoring and Control:
>   - Added 2nd source fan controllers (NCT7363) for fan duty control and
>     tach monitoring.
> - Power Monitoring:
>   - Added 2nd source HSC nodes (XDP710) for power sensor monitoring.
> - Address Conflicts:
>   - Removed all ina238 nodes due to address conflicts. Moved the driver
>     probe for ina238 to userspace.
> 
> Changes for PDB brick board
> - Power Monitoring:
>   - Add delta brick nodes for power sensor monitoring.
> 
> Signed-off-by: Potin Lai <potin.lai.pt@...il.com>
> ---
> Updating the Catalina DTS to support multiple PDB board sources.
> ---
> Changes in v2:
> - Add delta_brick nodes to support PDB brick board
> - Link to v1: https://lore.kernel.org/r/20250103-potin-catalina-dts-update-20250102-v1-1-b0b7a523c968@gmail.com
> ---
>  .../dts/aspeed/aspeed-bmc-facebook-catalina.dts    | 170 ++++++++++++++++++---
>  1 file changed, 147 insertions(+), 23 deletions(-)
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y for arch/arm/boot/dts/aspeed/' for 20250113-potin-catalina-dts-update-20250102-v2-1-1725117fe7a9@...il.com:

arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dtb: /ahb/apb/fsi@...9b000/cfam@0,0/hub@...0/cfam@1,0/i2c@...0: failed to match any schema with compatible: ['ibm,fsi-i2c-master']
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier.dtb: /ahb/apb/display@...e6000: failed to match any schema with compatible: ['aspeed,ast2600-gfx', 'syscon']
arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x570d4u.dtb: lpc@...89000: lpc-snoop@90: 'clocks' does not match any of the regexes: 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/mfd/aspeed-lpc.yaml#
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-catalina.dtb: /ahb/apb/bus@...8a000/i2c@.../i2c-mux@...i2c@...elta_brick@63: failed to match any schema with compatible: ['pmbus']
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-catalina.dtb: /ahb/apb/bus@...8a000/i2c@.../i2c-mux@...i2c@...elta_brick@64: failed to match any schema with compatible: ['pmbus']
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-catalina.dtb: /ahb/apb/bus@...8a000/i2c@.../i2c-mux@...i2c@...elta_brick@65: failed to match any schema with compatible: ['pmbus']
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-catalina.dtb: /ahb/apb/bus@...8a000/i2c@.../i2c-mux@...i2c@...elta_brick@66: failed to match any schema with compatible: ['pmbus']
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-catalina.dtb: /ahb/apb/bus@...8a000/i2c@.../i2c-mux@...i2c@...elta_brick@67: failed to match any schema with compatible: ['pmbus']
arch/arm/boot/dts/aspeed/aspeed-bmc-opp-nicole.dtb: /ahb/apb/display@...e6000: failed to match any schema with compatible: ['aspeed,ast2500-gfx', 'syscon']
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dtb: /ahb/apb/video@...00000: failed to match any schema with compatible: ['aspeed,ast2600-video-engine']
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-minerva.dtb: /ahb/apb/display@...e6000: failed to match any schema with compatible: ['aspeed,ast2600-gfx', 'syscon']