linux-kernel - Re: [PATCH v9 2/7] tools: arm64: Update sysreg.h header files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86ldvewx5g.wl-maz@kernel.org>
Date: Mon, 13 Jan 2025 15:28:43 +0000
From: Marc Zyngier <maz@...nel.org>
To: Mark Brown <broonie@...nel.org>
Cc: James Clark <james.clark@...aro.org>,
	kvmarm@...ts.linux.dev,
	oliver.upton@...ux.dev,
	suzuki.poulose@....com,
	coresight@...ts.linaro.org,
	James Clark <james.clark@....com>,
	Joey Gouly <joey.gouly@....com>,
	Zenghui Yu <yuzenghui@...wei.com>,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will@...nel.org>,
	Mike Leach <mike.leach@...aro.org>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Mark Rutland <mark.rutland@....com>,
	James Morse <james.morse@....com>,
	Shiqi Liu <shiqiliu@...t.edu.cn>,
	Anshuman Khandual <anshuman.khandual@....com>,
	"Rob Herring (Arm)" <robh@...nel.org>,
	Raghavendra Rao Ananta <rananta@...gle.com>,
	linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org,
	Aishwarya TCV <Aishwarya.TCV@....com>
Subject: Re: [PATCH v9 2/7] tools: arm64: Update sysreg.h header files

On Mon, 13 Jan 2025 15:07:21 +0000,
Mark Brown <broonie@...nel.org> wrote:
> 
> [1  <text/plain; us-ascii (quoted-printable)>]
> On Mon, Jan 06, 2025 at 02:24:37PM +0000, James Clark wrote:
> > From: James Clark <james.clark@....com>
> > 
> > Created with the following:
> > 
> >   cp include/linux/kasan-tags.h tools/include/linux/
> >   cp arch/arm64/include/asm/sysreg.h tools/arch/arm64/include/asm/
> > 
> > Update the tools copy of sysreg.h so that the next commit to add a new
> > register doesn't have unrelated changes in it. Because the new version
> > of sysreg.h includes kasan-tags.h, that file also now needs to be copied
> > into tools.
> 
> This breaks the build of the KVM selftests:
> 
> aarch64/aarch32_id_regs.c:150:16: error: use of undeclared identifier 'ID_AA64PFR0_EL1_ELx_64BIT_ONLY'
>   150 |         return el0 == ID_AA64PFR0_EL1_ELx_64BIT_ONLY;
>       |                       ^
> 1 warning and 1 error generated.
> 
> since it's pulled over the changes in 056600ff7330 ("arm64/cpufeature:
> Replace custom macros with fields from ID_AA64PFR0_EL1") but not updated
> the test to reflect this.

Thanks for the heads up. I've stashed a fix on top, which hopefully
will be in next tomorrow.

	M.

-- 
Without deviation from the norm, progress is not possible.