linux-kernel - Re: [PATCH] mmc: hi3798mv200: Use syscon_regmap_lookup_by_phandle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFqya3XCkfMjmUtupNJiV0w2bDdpgcPNfZpJcqEuBv1r4A@mail.gmail.com>
Date: Mon, 13 Jan 2025 16:37:30 +0100
From: Ulf Hansson <ulf.hansson@...aro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Jaehoon Chung <jh80.chung@...sung.com>, linux-mmc@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mmc: hi3798mv200: Use syscon_regmap_lookup_by_phandle_args

On Sat, 11 Jan 2025 at 19:54, Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
>
> Use syscon_regmap_lookup_by_phandle_args() which is a wrapper over
> syscon_regmap_lookup_by_phandle() combined with getting the syscon
> argument.  Except simpler code this annotates within one line that given
> phandle has arguments, so grepping for code would be easier.
>
> There is also no real benefit in printing errors on missing syscon
> argument, because this is done just too late: runtime check on
> static/build-time data.  Dtschema and Devicetree bindings offer the
> static/build-time check for this already.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/dw_mmc-hi3798mv200.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-hi3798mv200.c b/drivers/mmc/host/dw_mmc-hi3798mv200.c
> index cce174b5249b..5791a975a944 100644
> --- a/drivers/mmc/host/dw_mmc-hi3798mv200.c
> +++ b/drivers/mmc/host/dw_mmc-hi3798mv200.c
> @@ -181,7 +181,6 @@ static int dw_mci_hi3798mv200_init(struct dw_mci *host)
>  {
>         struct dw_mci_hi3798mv200_priv *priv;
>         struct device_node *np = host->dev->of_node;
> -       int ret;
>
>         priv = devm_kzalloc(host->dev, sizeof(*priv), GFP_KERNEL);
>         if (!priv)
> @@ -199,15 +198,12 @@ static int dw_mci_hi3798mv200_init(struct dw_mci *host)
>                 return dev_err_probe(host->dev, PTR_ERR(priv->drive_clk),
>                                      "failed to get enabled ciu-drive clock\n");
>
> -       priv->crg_reg = syscon_regmap_lookup_by_phandle(np, "hisilicon,sap-dll-reg");
> +       priv->crg_reg = syscon_regmap_lookup_by_phandle_args(np, "hisilicon,sap-dll-reg",
> +                                                            1, &priv->sap_dll_offset);
>         if (IS_ERR(priv->crg_reg))
>                 return dev_err_probe(host->dev, PTR_ERR(priv->crg_reg),
>                                      "failed to get CRG reg\n");
>
> -       ret = of_property_read_u32_index(np, "hisilicon,sap-dll-reg", 1, &priv->sap_dll_offset);
> -       if (ret)
> -               return dev_err_probe(host->dev, ret, "failed to get sample DLL register offset\n");
> -
>         host->priv = priv;
>         return 0;
>  }
> --
> 2.43.0
>