linux-kernel - Re: [PATCH 0/2] checkpatch: Add support for Checkpatch-ignore patch footer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z4U9R2m0xVTRMlkk@casper.infradead.org>
Date: Mon, 13 Jan 2025 16:20:23 +0000
From: Matthew Wilcox <willy@...radead.org>
To: Brendan Jackman <jackmanb@...gle.com>
Cc: Andy Whitcroft <apw@...onical.com>, Joe Perches <joe@...ches.com>,
	Dwaipayan Ray <dwaipayanray1@...il.com>,
	Lukas Bulwahn <lukas.bulwahn@...il.com>,
	Jonathan Corbet <corbet@....net>, linux-kernel@...r.kernel.org,
	workflows@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH 0/2] checkpatch: Add support for Checkpatch-ignore patch
 footer

On Mon, Jan 13, 2025 at 04:04:21PM +0000, Brendan Jackman wrote:
> Checkpatch sometimes has false positives. This makes it less useful for
> automatic usage: tools like b4 [0] can run checkpatch on all of your
> patches and give you a quick overview. When iterating on a branch, it's
> tiresome to manually re-check that any errors are known false positives.
> 
> This patch adds a feature to record in the commit message that a patch
> might produce a certain checkpatch error, and that this is an expected
> false positive. Recording this information in the patch itself can also
> highlight it to reviewers, so they can make a judgment as to whether
> it's appropriate to ignore.

I think humans should always ignore checkpatch.  It's basically
worthless.