linux-kernel - Re: [PATCH v5 09/17] arm64: pgtable: move pagetable_dtor() to __tlb_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250113162931.GB14101@willie-the-truck>
Date: Mon, 13 Jan 2025 16:29:32 +0000
From: Will Deacon <will@...nel.org>
To: Qi Zheng <zhengqi.arch@...edance.com>
Cc: peterz@...radead.org, agordeev@...ux.ibm.com, kevin.brodsky@....com,
	alex@...ti.fr, andreas@...sler.com, palmer@...belt.com,
	tglx@...utronix.de, david@...hat.com, jannh@...gle.com,
	hughd@...gle.com, yuzhao@...gle.com, willy@...radead.org,
	muchun.song@...ux.dev, vbabka@...nel.org,
	lorenzo.stoakes@...cle.com, akpm@...ux-foundation.org,
	rientjes@...gle.com, vishal.moola@...il.com, arnd@...db.de,
	aneesh.kumar@...nel.org, npiggin@...il.com,
	dave.hansen@...ux.intel.com, rppt@...nel.org, ryan.roberts@....com,
	linux-mm@...ck.org, linux-arm-kernel@...ts.infradead.org,
	linuxppc-dev@...ts.ozlabs.org, linux-riscv@...ts.infradead.org,
	linux-s390@...r.kernel.org, sparclinux@...r.kernel.org,
	linux-kernel@...r.kernel.org, x86@...nel.org,
	linux-arch@...r.kernel.org, linux-csky@...r.kernel.org,
	linux-hexagon@...r.kernel.org, loongarch@...ts.linux.dev,
	linux-m68k@...ts.linux-m68k.org, linux-mips@...r.kernel.org,
	linux-openrisc@...r.kernel.org, linux-sh@...r.kernel.org,
	linux-um@...ts.infradead.org
Subject: Re: [PATCH v5 09/17] arm64: pgtable: move pagetable_dtor() to
 __tlb_remove_table()

On Wed, Jan 08, 2025 at 02:57:25PM +0800, Qi Zheng wrote:
> Move pagetable_dtor() to __tlb_remove_table(), so that ptlock and page
> table pages can be freed together (regardless of whether RCU is used).
> This prevents the use-after-free problem where the ptlock is freed
> immediately but the page table pages is freed later via RCU.
> 
> Page tables shouldn't have swap cache, so use pagetable_free() instead of
> free_page_and_swap_cache() to free page table pages.
> 
> Signed-off-by: Qi Zheng <zhengqi.arch@...edance.com>
> Suggested-by: Peter Zijlstra (Intel) <peterz@...radead.org>
> Reviewed-by: Kevin Brodsky <kevin.brodsky@....com>
> Cc: linux-arm-kernel@...ts.infradead.org
> ---
>  arch/arm64/include/asm/tlb.h | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)

Acked-by: Will Deacon <will@...nel.org>

Will