linux-kernel - Re: [PATCH RFCv2 08/13] iommu: Turn iova

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250113164037.GO5556@nvidia.com>
Date: Mon, 13 Jan 2025 12:40:37 -0400
From: Jason Gunthorpe <jgg@...dia.com>
To: Nicolin Chen <nicolinc@...dia.com>
Cc: will@...nel.org, robin.murphy@....com, kevin.tian@...el.com,
	tglx@...utronix.de, maz@...nel.org, alex.williamson@...hat.com,
	joro@...tes.org, shuah@...nel.org, reinette.chatre@...el.com,
	eric.auger@...hat.com, yebin10@...wei.com, apatel@...tanamicro.com,
	shivamurthy.shastri@...utronix.de, bhelgaas@...gle.com,
	anna-maria@...utronix.de, yury.norov@...il.com, nipun.gupta@....com,
	iommu@...ts.linux.dev, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, kvm@...r.kernel.org,
	linux-kselftest@...r.kernel.org, patches@...ts.linux.dev,
	jean-philippe@...aro.org, mdf@...nel.org, mshavit@...gle.com,
	shameerali.kolothum.thodi@...wei.com, smostafa@...gle.com,
	ddutile@...hat.com
Subject: Re: [PATCH RFCv2 08/13] iommu: Turn iova_cookie to dma-iommu private
 pointer

On Fri, Jan 10, 2025 at 07:32:24PM -0800, Nicolin Chen wrote:
> Now, iommufd has its own iommufd_sw_msi using iommufd_hwpt, the iommufd
> owned domain's private pointer. Similarly, iova_cookie can be seen as a
> dma-iommu owned domain's private pointer. So, move iova_cookie into the
> union.

This commit message would be clearer as:

Now that iommufd does not rely on dma-iommu.c for any purpose we can
combine the dma-iommu.c iova_cookie and the iommufd_hwpt under the
same union. This union is effectively 'owner data' can be used by the
entity that allocated the domain. Note that legacy vfio type1 flows
continue to use dma-iommu.c for sw_msi and still need iova_cookie.

Jason